1175058 - TrackBuffersManager will error on some fragmented input.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Example of such problem:
http://people.mozilla.org/~jyavenard/tests/mse_mp4/errorappend.html

Something not handled properly by the trackbuffers manager demuxer...

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P1. Properly handle partial init and media header.

I thought you would love to review one last patch :)

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8622952 [details] [diff] [review]
P1. Properly handle partial init and media header.

Actually this works because of a bug in the MP4 ContainerParser.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P1. Properly handle partial init and media header.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P2. Do not evict data until a full init segment has been received.

This prevented being able to read the init segment back from the MP4ContainerParser
should init segment had been added in multiple blocks.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: P3. Properly search for the required MP4 Atoms rather than make assumptions.

This is something we should have done a long time ago.

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8623421 [details] [diff] [review]
P3. Properly search for the required MP4 Atoms rather than make assumptions.

Review of attachment 8623421 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/ContainerParser.cpp
@@ +268,5 @@
> +      uint64_t size = reader.ReadU32();
> +      const uint8_t* typec = reader.Peek(4);
> +      uint32_t type = reader.ReadU32();
> +      MSE_DEBUGV(MP4ContainerParser ,"Checking atom:'%c%c%c%c'",
> +                typec[0], typec[1], typec[2], typec[3]);

This is nasty. We need to find a better way to do it.

Comment 7

[Jean-Yves Avenard [:jya]]

What is? Displaying the type name?
How is that nasty? It's encoded in big endian. No much more elegant ways to read 4 bytes

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97ace5e97d7b
https://hg.mozilla.org/integration/mozilla-inbound/rev/993db9bb3099
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7aad45010b6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97ace5e97d7b
https://hg.mozilla.org/mozilla-central/rev/993db9bb3099
https://hg.mozilla.org/mozilla-central/rev/d7aad45010b6