1179397 - Assert/Crash running "fetch-event-async-respond-with.https.html" wpt service worker test in Nightly

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Noemí Freire (:noemi)]

Attachment: Nightly_Crash_wpt_sw_fetch-event-async-respond-with.https.rtf

A Nightly crash occurs when executing "fetch-event-async-respond-with.https.html" wpt test such as |./mach web-platform-tests _mozilla/service-workers/service-worker/fetch-event-async-respond-with.https.html| with today's (7/1) master build

The assertion failure shown is as follows:
"Assertion failure: workerPrivate, at /Users/noef/Documents/mozilla-central/dom/workers/ServiceWorker.cpp:93"

Please find attached the crash report corresponding to this

Comment 1

[(no longer active)]

This is another instance of bug 1179401.

Comment 2

[Noemí Freire (:noemi)]

Hi,

just checked on m-c (89732fcdb0ba revision) once bug 1179401 has been landed and the result obtained when running |./mach web-platform-tests _mozilla/service-workers/service-worker/fetch-event-async-respond-with.https.html| is as follows:

Summary

Harness status: OK

Found 1 tests
1 Fail
Details

Result
Fail

Test Name
Calling respondWith asynchronously throws an exception	

Message
promise_test: Unhandled rejection with value: object "InvalidStateError: An attempt was made to use an object t..."

@https://web-platform.test:8443/_mozilla/service-workers/service-worker/fetch-event-async-respond-with.https.html:7:1

Ehsan, should we open a new bug?. Thanks!

Comment 3

[(no longer active)]

No, we can reopen this one.

Comment 4

[(no longer active)]

Attachment: Disallow FetchEvent.respondWith() when the dispatch flag is unset

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dd6a4a5da3d

Comment 6

[(no longer active)]

Comment on attachment 8671024 [details] [diff] [review]
Disallow FetchEvent.respondWith() when the dispatch flag is unset

Approval Request Comment
[Feature/regressing bug #]: service workers
[User impact if declined]: spec compliance issue
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: no risk
[String/UUID change made/needed]: none

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dd6a4a5da3d

Comment 8

[Noemí Freire (:noemi)]

Hi,

just checked on m-c (0b69d304f861 revision) and the test successfully runs. Thanks for fixing it!

Summary

Harness status: OK

Found 1 tests
1 Pass
Details
Result	Test Name
Pass	Calling respondWith asynchronously throws an exception

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8671024 [details] [diff] [review]
Disallow FetchEvent.respondWith() when the dispatch flag is unset

Fix for crash in service workers, ok to uplift to aurora.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression and part of a feature we're aiming at 43.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca97cca1a50c

Comment 12

[Carsten Book [:Tomcat]]

Sorry had to backout and recheckin this since this turned innocent for a memory leaks, sorry for the hassle