1180737 - "Harness status: OK" + failing test when running "update.https.html" test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemí Freire (:noemi)]

Checked with 7/6 master build

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/update.https.html|

Result:
* Harness status: OK
* Found 1 test
* 1 Fail:
** Update a registration
*** assert_unreached: unregister and register should not fail: The expression cannot be converted to return the specified type. Reached unreachable code
**** unreached_rejection/<@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:42:7 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:1387:1 Promise*service_worker_unregister_and_register@https://web-platform.test:8443/_mozilla/service-workers/service-worker/resources/test-helpers.sub.js:8:10 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/update.https.html:13:12 Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1363:20 promise_test@https://web-platform.test:8443/resources/testharness.js:520:25 @https://web-platform.test:8443/_mozilla/service-workers/service-worker/update.https.html:7:1 
* Traces: https://pastebin.mozilla.org/8838616

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1180737 - Add update-test.py and update test to latest version. r=bkelly.

Bug 1180737 - Add update-test.py and update test to latest version. r?bkelly.

Added update-test.py which is a conversion of Blink update-test.php to deliver workers with different mime types.
Updated test file to latest version to check for SecurityError.
Dealt with the usual waiting/active issue.
Update web-platform-tests expected data

Comment 2

[Noemí Freire (:noemi)]

Hi,

Patch provided by Nikhil so assigning this to him. Please, feel free to change it as needed. Thanks!

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8655184 [details]
MozReview Request: Bug 1180737 - Add update-test.py and update test to latest version. r=bkelly.

https://reviewboard.mozilla.org/r/17857/#review15979

::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/update-worker.py:8
(Diff revision 1)
> +    print 'NSM mode is now', mode

nit: debug left in

::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/update-worker.py:34
(Diff revision 1)
> +    return 200, headers, '// %s' % (time.time())

nit: I think you taught me 200 is unnecessary here.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8655184 [details]
> MozReview Request: Bug 1180737 - Add update-test.py and update test to
> latest version. r?bkelly.
> 
> https://reviewboard.mozilla.org/r/17857/#review15979
> 
> :::
> testing/web-platform/mozilla/tests/service-workers/service-worker/resources/
> update-worker.py:8
> (Diff revision 1)
> > +    print 'NSM mode is now', mode
> 
> nit: debug left in
> 
> :::
> testing/web-platform/mozilla/tests/service-workers/service-worker/resources/
> update-worker.py:34
> (Diff revision 1)
> > +    return 200, headers, '// %s' % (time.time())
> 
> nit: I think you taught me 200 is unnecessary here.

Haha, yes, I was running into some python error without good location info and I thought maybe this was it. I'll revert it.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8655184 [details]
MozReview Request: Bug 1180737 - Add update-test.py and update test to latest version. r=bkelly.

Bug 1180737 - Add update-test.py and update test to latest version. r=bkelly.

Added update-test.py which is a conversion of Blink update-test.php to deliver workers with different mime types.
Updated test file to latest version to check for SecurityError.
Dealt with the usual waiting/active issue.
Update web-platform-tests expected data

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40e6330dd773

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40e6330dd773

Comment 8

[Noemí Freire (:noemi)]

Hi,

just checked on m-c (74fbd245369c revision) and the test successfully runs. Thanks for fixing it!

Summary

Harness status: OK

Found 1 tests
1 Pass
Details
Result	Test Name
Pass	Update a registration