1182610 - crash in mozilla::OriginAttributes::CreateSuffix(nsACString_internal&)

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[(Away)]

This bug was filed from the Socorro interface and is 
report bp-fabb0e9f-0d96-4be4-8538-571e52150708.
=============================================================

Somewhat-high crash on aurora 41. Filing this as separate from bug 1171432 because I don't see ServiceWorkers on the stack. Most of the URLs are local files.

  MOZ_RELEASE_ASSERT(mAppId != nsIScriptSecurityManager::UNKNOWN_APP_ID);

00 00192a18 6adb6c1d xul!mozilla::OriginAttributes::CreateSuffix+0x58
01 00192a84 6a89e901 xul!mozilla::BasePrincipal::GetOrigin+0x3b
02 00192a98 6a6f83dd xul!NS_InvokeByIndex+0x27
03 00192fe4 6a327cd7 xul!XPC_WN_GetterSetter+0x80d
04 0019330c 6a2fe97c xul!js::Invoke+0x137
05 001933c0 6a3064c6 xul!js::Invoke+0x1cc
06 001936fc 6a3296dd xul!js::GetProperty+0x636
07 00193768 6a32f695 xul!GetPropertyOperation+0x11d

Comment 1

[Bobby Holley (:bholley)]

Yeah, my bad.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Check for UNKNOWN_APP_ID in nsIPrincipal::GetOrigin. v1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/806ec30c5992

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8634404 [details] [diff] [review]
Check for UNKNOWN_APP_ID in nsIPrincipal::GetOrigin. v1

Approval Request Comment
[Feature/regressing bug #]: bug 1165162
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]: tests with patch
[Risks and why]: very low risk
[String/UUID change made/needed]: None

Comment 5

[(Away)]

> [Describe test coverage new/current, TreeHerder]: tests with patch
Always good to see, thanks!

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8634404 [details] [diff] [review]
Check for UNKNOWN_APP_ID in nsIPrincipal::GetOrigin. v1

Patch with crash-test. Approved.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/adf1daf281fd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/806ec30c5992

Comment 9

[(Away)]

There's still a small handful of these on 41b9, but they get up-weighted by our scoring system for being repeated startup crashes.

Bobby, does anything stand out here? I don't have the mAppId available, unfortunately:
https://crash-stats.mozilla.com/report/index/5dff0416-f9bc-49c2-9280-8984d2150912
https://crash-stats.mozilla.com/report/index/96375197-b0be-49f4-bff9-d28222150912

Comment 10

[Bobby Holley (:bholley)]

Thanks for raising that dmajor - filed bug 1205456.