1183689 - [Netflix] error F7053-1803: Having moz-safe-about+home in storage/permanent and storage/persistent breaks temporary storage initialization

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P1)

Description

[Jan Varga [:janv]]

This only happens when there's no storage/default directory which shouldn't happen normally. I guess storage/default is removed manually or by some script.
Having storage/default is a sign to not try upgrade storage/persistent (if it exists) to storage/default.
I think we should also check for storage/permanent existence.

Comment 1

[Jan Varga [:janv]]

Btw, this is how I reproduced the bug:
1. Launch FF 35
2. Create new profile
3. Quit FF 35
4. Launch current nightly (with the same profile)
5. Quit current nightly
6. Manually remove <profile>/storage/default
7. Launch FF 35
8. Quit FF 35
9. Launch current nightly

Quota manager will fail to upgrade storage/persistent (and thus to initialize temporary storage) at this point. Line: 5254:
rv = originProps.mDirectory->MoveTo(permanentStorageDir, EmptyString());

Comment 2

[Jan Varga [:janv]]

(In reply to Jan Varga [:janv] from comment #0)
> I think we should also check for storage/permanent existence.

Actually this is not a great idea, we could crash in the middle of the storage directory upgrade, so we need to finish it.

Comment 3

[Jan Varga [:janv]]

Attachment: patch

This works for me.
Kyle, can you verify on windows with the specific profile ?
Thanks

Comment 4

[Chris Peterson [:cpeterson]]

This QuotaManager bug is the cause of Netflix EME error F7053-1803.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It is *a* cause of the error, I'm not certain (although it may be) that it is the only one.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8633552 [details] [diff] [review]
patch

Review of attachment 8633552 [details] [diff] [review]:
-----------------------------------------------------------------

With this patch and the profile cpearce gave me we now fail loading with F7053-1807, and there are no QuotaManager warnings in the log.

Comment 7

[Chris Peterson [:cpeterson]]

Joe or John, what is error F7053-1807?

Comment 8

[Joe Steele]

According to Kevin Gallagher's email -- this is an indexedDB error (indexDB.open never called back). This is not something the CDM is involved in AFAICT.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

I see F7053-1803 when I start Netflix in a clean profile and start a private browsing window and login in the PB window and try to play a video.

Could users using Private Browsing mode explain this error?

Log from my Repro:

Version: 3.0000.043.051
JsSid: 14376090246154, Epoch: 1437609037, Start: 1437609024, TimeZone: -720
Href: http://www.netflix.com/watch/70272832?trackId=13462260&tctx=0%252C0%252Cb8e66d85-e1c8-4967-9376-3fa9f42118ec-48165391
UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
--------------------------------------------------------------------------------
3.899|0|I|Ext| object.pool: Setting play context:, location: WATCHNOW, row: 0, rank: 0, request_id: b8e66d85-e1c8-4967-9376-3fa9f42118ec-48165391
3.900|1|I|Playback| Playback created, MovieId: 70272832, TrackingId: 13462260, Xid: 14376090244548, AccountKey: undefined
3.902|1|I|Playback| Playback loading, MovieId: 70272832, TrackingId: 13462260, Xid: 14376090244548, AccountKey: undefined
3.902|1|I|Playback| Playback state changed, From: 0, To: 1
4.026|0|E|Storage| IndexedDB open error
onerror: InvalidStateError
4.026|1|E|Playback| Fatal playback error, Error: [PlayerError #F7053-1803] onerror: InvalidStateError, HandleDelay: undefined
4.026|1|I|Playback| Playback closing, MovieId: 70272832, TrackingId: 13462260, Xid: 14376090244548, AccountKey: undefined, ErrorCode: F7053-1803
4.027|1|I|Playback| Playback state changed, From: 1, To: 3
4.030|1|I|Playback| Playback state changed, From: 3, To: 4

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Chris Pearce (:cpearce) from comment #9)
> I see F7053-1803 when I start Netflix in a clean profile and start a private
> browsing window and login in the PB window and try to play a video.
> 
> Could users using Private Browsing mode explain this error?

IndexedDB is disabled in private browsing mode (bug 781982).

Comment 11

[Kevin]

Private browsing mode does cause this issue, we discovered this back in May and made a request to distinguish between a IndexedDb error and IndexedDb not available. The last thought on the thread was for us to create a dummy database to see if it works, if it does then IndexedDb is available. 

While we can do this there are a couple of issues
  1) It would increase our play delay, not sure how long it takes to create and delete a new DB
  2) It increases the complexity of the code in that we would have to do this explicitly for Firefox

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a983b06b1be3

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Jan: Is this patch safe enough to uplift to Beta? We'd like this fix on the 40 train ideally, and the code freeze for that is scheduled for 30 July.

Comment 14

[Jan Varga [:janv]]

(In reply to Chris Pearce (:cpearce) from comment #13)
> Jan: Is this patch safe enough to uplift to Beta? We'd like this fix on the
> 40 train ideally, and the code freeze for that is scheduled for 30 July.

Yes, I think it's safe enough.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a983b06b1be3

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

[Tracking Requested - why for this release]: This can cause a playback failure on Netflix; we should uplift the fix.

Comment 17

[Chris Pearce [:cpearce (Not reading bugmail)]]

Aurora try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5daa981622fc

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38688ee5b64e

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked.

Comment 19

[Jan Varga [:janv]]

Comment on attachment 8633552 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1083927

[User impact if declined]: Netflix can't access its IndexedDB database

[Describe test coverage new/current, TreeHerder]: Tested only manually.

[Risks and why]: It's been only a few days since this landed on mozilla-central, as far as I know, this didn't regress anything. In any case the patch is very simple and can be easily backed out if there are problems.

[String/UUID change made/needed]: None

Comment 20

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Jan Varga [:janv] from comment #19)
> [User impact if declined]: Netflix can't access its IndexedDB database

Is this an absolute statement or does this only occur in certain cases? How does this issue appear to the end user?

> [Describe test coverage new/current, TreeHerder]: Tested only manually.
> 
> [Risks and why]: It's been only a few days since this landed on
> mozilla-central, as far as I know, this didn't regress anything. In any case
> the patch is very simple and can be easily backed out if there are problems.

The few days on m-c may be enough to show that nothing is horribly broken in IndexedDB but doesn't demonstrate that this fixes the Netflix issue. We're at our final beta in the 40 cycle. Any backout would have to come Sunday or Monday morning before we gtb with the 40 RC.

Unless this patch is a hard requirement for EME, I think we should defer the fix to 41.

Comment 21

[Jan Varga [:janv]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #20)
> (In reply to Jan Varga [:janv] from comment #19)
> > [User impact if declined]: Netflix can't access its IndexedDB database
> 
> Is this an absolute statement or does this only occur in certain cases? How
> does this issue appear to the end user?

I only know that a couple of testers here upgraded their browser from
38 to 39 and got an error (indexDB.open called back with an error).
The error name was UnknownError.

> 
> > [Describe test coverage new/current, TreeHerder]: Tested only manually.
> > 
> > [Risks and why]: It's been only a few days since this landed on
> > mozilla-central, as far as I know, this didn't regress anything. In any case
> > the patch is very simple and can be easily backed out if there are problems.
> 
> The few days on m-c may be enough to show that nothing is horribly broken in
> IndexedDB but doesn't demonstrate that this fixes the Netflix issue. We're
> at our final beta in the 40 cycle. Any backout would have to come Sunday or
> Monday morning before we gtb with the 40 RC.
> 
> Unless this patch is a hard requirement for EME, I think we should defer the
> fix to 41.

Well in that case I'm deferring to cpearce, he told me that ideally we'd need it landed before the 40b9 build on Thursday PST.

Comment 22

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #20)
> (In reply to Jan Varga [:janv] from comment #19)
> > [User impact if declined]: Netflix can't access its IndexedDB database
> 
> Is this an absolute statement or does this only occur in certain cases? How
> does this issue appear to the end user?
> 
> > [Describe test coverage new/current, TreeHerder]: Tested only manually.
> > 
> > [Risks and why]: It's been only a few days since this landed on
> > mozilla-central, as far as I know, this didn't regress anything. In any case
> > the patch is very simple and can be easily backed out if there are problems.
> 
> The few days on m-c may be enough to show that nothing is horribly broken in
> IndexedDB but doesn't demonstrate that this fixes the Netflix issue. We're
> at our final beta in the 40 cycle. Any backout would have to come Sunday or
> Monday morning before we gtb with the 40 RC.
> 
> Unless this patch is a hard requirement for EME, I think we should defer the
> fix to 41.

I think we can take this in 41, and let it slide for 40.

Comment 23

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8633552 [details] [diff] [review]
patch

Let's land it on Aurora so we can get more users to start exercising this code. Also this patch has been in m-c for 2 days so seems safe to uplift.

Comment 24

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8633552 [details] [diff] [review]
patch

cpearce confirmed that this is not a hard requirement for 40 (comment 22). Beta-

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d134bf02ae4