1187113 - [EME] Add more logging around EME promise rejects and method calls

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

It would be handy to have more logging surround EME function calls, especially navigator.requestMediaKeySystemAccess(), and promise rejects.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add more logging

Add more logging around EME methods, particularly the ones that we have trouble with (i.e. we log not having a valid plugin-container voucher to console and in the exception message). Also log promise rejects/resolves, including the message that rejects.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8638226 [details] [diff] [review]
Patch: Add more logging

Review of attachment 8638226 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/eme/MediaKeys.cpp
@@ +148,5 @@
>  MediaKeys::SetServerCertificate(const ArrayBufferViewOrArrayBuffer& aCert, ErrorResult& aRv)
>  {
>    nsRefPtr<DetailedPromise>
> +    promise(MakePromise(aRv,
> +                        NS_LITERAL_CSTRING("MediaKeys.setServerCertificate")));

Inconsistent indent.

@@ +297,5 @@
>  MediaKeys::Init(ErrorResult& aRv)
>  {
>    nsRefPtr<DetailedPromise>
> +    promise(MakePromise(aRv,
> +                        NS_LITERAL_CSTRING("MediaKeys::Init()")));

MediaKeySystemAccess.createMediaKeys

Also indent is inconsistent with rest of patch.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8638226 [details] [diff] [review]
Patch: Add more logging

Review of attachment 8638226 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Navigator.cpp
@@ +2750,5 @@
> +        logMsg.AppendPrintf("initDataType='%s',",
> +          NS_ConvertUTF16toUTF8(op.mInitDataType).get());
> +      }
> +      logMsg.AppendPrintf("stateful='%s',",
> +        MediaKeysRequirementValues::strings[(size_t)op.mStateful]);

d'oh!

This needed to be:

MediaKeysRequirementValues::strings[(size_t)op.mStateful].value

Yay unsafe printf.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d03735ae65b8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d03735ae65b8