Closed
      
        Bug 1188062
      
      
        Opened 10 years ago
          Closed 10 years ago
      
        
    
  
Unship Request.context 
    Categories
(Core :: DOM: Service Workers, defect)
        Core
          
        
        
      
        
    
        DOM: Service Workers
          
        
        
      
        
    Tracking
()
        RESOLVED
        FIXED
        
    
  
        
            mozilla42
        
    
  
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed | 
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
| 
        
        
         13.18 KB,
          patch         
       | 
      
           baku
 :
              
              review+
           | 
      Details | Diff | Splinter Review | 
According to our IRC conversations today, we decided that we are not yet ready to ship Request.context.  See <https://github.com/whatwg/fetch/issues/93#issuecomment-125289983> which is my feedback on the spec.
| Assignee | ||
          Comment 1•10 years ago
           
         | 
      ||
        Attachment #8639547 -
        Flags: review?(amarchesini)
          Updated•10 years ago
           
         | 
      
Keywords: dev-doc-needed, 
          
            site-compat
          Comment 2•10 years ago
           
         | 
      ||
Comment on attachment 8639547 [details] [diff] [review]
Unship Request.context
Review of attachment 8639547 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/fetch/Request.cpp
@@ +14,5 @@
>  #include "mozilla/dom/Fetch.h"
>  #include "mozilla/dom/Promise.h"
>  #include "mozilla/dom/URL.h"
>  #include "mozilla/dom/workers/bindings/URL.h"
> +#include "mozilla/dom/WorkerPrivate.h"
alphabetic order.
        Attachment #8639547 -
        Flags: review?(amarchesini) → review+
          Comment 4•10 years ago
           
         | 
      ||
Status: NEW → RESOLVED
Closed: 10 years ago
          status-firefox42:
          --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
          Comment 5•10 years ago
           
         | 
      ||
I've added a footnote to the browser compat table to make this clear:
https://developer.mozilla.org/en-US/docs/Web/API/Request/context
The page has been marked deprecated too, as the feature is no longer in the spec.
I've also checked, and a note has been included in the Firefox release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/42
Keywords: dev-doc-needed → dev-doc-complete
          Comment 6•10 years ago
           
         | 
      ||
The site compat doc is here:
https://www.fxsitecompat.com/en-US/docs/2015/request-context-has-been-removed/
          You need to log in
          before you can comment on or make changes to this bug.
        
Description
•