1189945 - Remove nsIChannel CorsMode flag and set Request.mode based on nsILoadInfo securityFlags instead

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Once bug 1182535 updates enough of the network callsites we should switch the ServiceWorkerManager code to using nsILoadInfo::GetSecurityFlags() to set the Request.mode value.  Once this is done we can remove the nsIChannel CorsMode flag.  The new nsILoadInfo securityFlags is more robust and being integrated with the rest of the tree.

For example, the securityFlags will actually reflect same-origin policies which are currently not reflected in actual values on CorsMode.

Note, we will still need to exempt the mode for document nsIContentPolicy values since navigations need to be same-origin, but the security flags won't reflect that.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I have a patch in bug 1184967 that adds the conversion from securityFlags.

Comment 2

[Andrew Overholt [:overholt]]

Ben said elsewhere that this is nice but not entirely necessary for the initial shipping of SW.  He noted some changes that he's made and others still needed but I didn't catch them quickly enough to type them here.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

This is a compat issue because the legacy code paths don't reliably provide the correct FetchEvent.request values.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Bug 1776414 changed nsIHttpChannelInternal's corsMode to requestMode addressing the channel change desired, plus the patch in comment 1 I believe performed the conversion of the use already.