Closed
Bug 1201636
Opened 10 years ago
Closed 10 years ago
use channel->asyncOpen2() in modules/libjar/zipwriter/nsZipWriter.cpp
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.62 KB,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8656739 -
Flags: review?(jonas)
Comment on attachment 8656739 [details] [diff] [review]
bug_1201636_nszipwriter.patch
Review of attachment 8656739 [details] [diff] [review]:
-----------------------------------------------------------------
Can you fix the test here to create a channel with a securitymode set. That seems to be the only user of addEntryChannel
http://mxr.mozilla.org/mozilla-central/source/modules/libjar/zipwriter/test/unit/test_asyncadd.js#72
r=me with that fixed.
Attachment #8656739 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Sure can update the test. Carrying over r+ from Jonas.
Attachment #8656739 -
Attachment is obsolete: true
Attachment #8656792 -
Flags: review+
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•