1201810 - Move jit/XXX/BaselineIC-XXX.cpp to jit/XXX/SharedIC-XXX.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

Unary and binary arith have code in the baselineIC, but are already moved to sharedIC. Move the platform specific code also to such a file.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Part 0: Make x86/x64 a bit more similar

Very small change

Comment 2

[Hannes Verschore [:h4writer]]

Attachment: Actual patch

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8657117 [details] [diff] [review]
Part 0: Make x86/x64 a bit more similar

Review of attachment 8657117 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/x64/SharedICHelpers-x64.h
@@ +95,5 @@
>  EmitIonTailCallVM(JitCode* target, MacroAssembler& masm, uint32_t stackSize)
>  {
>      ScratchRegisterScope scratch(masm);
>  
> +    masm.loadPtr(Address(esp, stackSize), eax);

I think this should be `scratch` instead of eax, as it was before.

::: js/src/jit/x86/SharedICHelpers-x86.h
@@ +94,5 @@
>  
>  inline void
>  EmitIonTailCallVM(JitCode* target, MacroAssembler& masm, uint32_t stackSize)
>  {
> +    // For tail calls, find the already pushed JitFrame_IonJS signifying the

Shouldn't we add this comment to the x64 code as well?

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8657125 [details] [diff] [review]
Actual patch

Review of attachment 8657125 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/moz.build
@@ +396,5 @@
>              'jit/x64/Assembler-x64.cpp',
>              'jit/x64/Bailouts-x64.cpp',
>              'jit/x64/BaselineCompiler-x64.cpp',
>              'jit/x64/BaselineIC-x64.cpp',
> +            'jit/x64/SharedIC-x64.cpp',

I'd add it between MacroAssembler-x64 and Trampoline-x64 to keep the list sorted, same below.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01324f0b7651
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7edac29dad

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01324f0b7651
https://hg.mozilla.org/mozilla-central/rev/8d7edac29dad