1203160 - Turn service workers and fetch interception on in Fennec Nightly

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Comment 1

[(no longer active)]

Attachment: Turn service workers and fetch interception on in Fennec Nightly

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8658775 [details] [diff] [review]
Turn service workers and fetch interception on in Fennec Nightly

Review of attachment 8658775 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/app/mobile.js
@@ +937,5 @@
> +
> +// Enable service workers and fetch interception on Nightly Fennec
> +#ifdef NIGHTLY_BUILD
> +pref("dom.serviceWorkers.enabled", true);
> +pref("dom.serviceWorkers.interception.enabled", true);

Could you also enable Push on nightly? Just dom.push.enabled.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Nikhil Marathe [:nsm] (please needinfo?) from comment #2)
> Comment on attachment 8658775 [details] [diff] [review]
> Turn service workers and fetch interception on in Fennec Nightly
> 
> Review of attachment 8658775 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/app/mobile.js
> @@ +937,5 @@
> > +
> > +// Enable service workers and fetch interception on Nightly Fennec
> > +#ifdef NIGHTLY_BUILD
> > +pref("dom.serviceWorkers.enabled", true);
> > +pref("dom.serviceWorkers.interception.enabled", true);
> 
> Could you also enable Push on nightly? Just dom.push.enabled.

Push on mobile is not ready. It requires support/integration with Google Cloud Messaging.

Comment 4

[(no longer active)]

Attachment: Part 2: Fix the interfaces tests to allow SW interfaces for non-release Fennec

Comment 5

[(no longer active)]

Yeah, not blocking on push for now...

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5019d220cbfc
https://hg.mozilla.org/integration/mozilla-inbound/rev/43c7686faffd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5019d220cbfc
https://hg.mozilla.org/mozilla-central/rev/43c7686faffd