1206894 - Enable asynchronous dispatching of fetch events

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

This refactoring patch separates the preparation of the fetch event
object from its dispatching, so that consumers would be able to
dispatch the event asynchronously.

Comment 1

[(no longer active)]

Attachment: Enable asynchronous dispatching of fetch events

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 8663869 [details] [diff] [review]
Enable asynchronous dispatching of fetch events

Review of attachment 8663869 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libjar/InterceptedJARChannel.cpp
@@ +132,5 @@
> +  rv = dispatcher->Dispatch();
> +  if (NS_WARN_IF(NS_FAILED(rv))) {
> +    rv = ResetInterception();
> +    NS_WARN_IF_FALSE(NS_SUCCEEDED(rv),
> +        "Failed to dispatch the fetch event");

This should refer to ResetInterception failing.

::: netwerk/base/nsINetworkInterceptController.idl
@@ +25,5 @@
>   * the actual channel. nsIInterceptedChannel is expected to be implemented by objects
>   * which do not implement nsIChannel.
>   */
>  
> +[scriptable, uuid(40851f73-f799-4a22-a69b-05e0371ee373)]

Unnecessary.

::: netwerk/protocol/http/InterceptedChannel.cpp
@@ +68,5 @@
>      }
> +    rv = dispatcher->Dispatch();
> +    if (NS_WARN_IF(NS_FAILED(rv))) {
> +      rv = ResetInterception();
> +      NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Failed to dispatch the fetch event");

This message should refer to ResetInterception failing.

Comment 3

[(no longer active)]

(In reply to Josh Matthews [:jdm] from comment #2)
> ::: netwerk/base/nsINetworkInterceptController.idl
> @@ +25,5 @@
> >   * the actual channel. nsIInterceptedChannel is expected to be implemented by objects
> >   * which do not implement nsIChannel.
> >   */
> >  
> > +[scriptable, uuid(40851f73-f799-4a22-a69b-05e0371ee373)]
> 
> Unnecessary.

Unfortunately it's needed because of bug 1171721.  :(

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6aabbc12983c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/201ccc2e2e76

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6aabbc12983c
https://hg.mozilla.org/mozilla-central/rev/201ccc2e2e76