1210235 - Pref off any signed web packaged app things

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Henry Chang [:hchang]]

We need a preference to isolate all the operations on signed app and pref off it. The purpose is to avoid shipping pre-mature signed package app code.

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1210235.patch

Comment 2

[Henry Chang [:hchang]]

I believe the attached patch also addresses the requirement mentioned in Bug 1205623.

Comment 3

[Henry Chang [:hchang]]

Comment on attachment 8672486 [details] [diff] [review]
Bug1210235.patch

Hi Valentin,

The patch is intended to do the verification only when 'network.http.packaged-signed-apps-enabled' is true and the package has a signature.

The purpose of adding preference 'network.http.packaged-signed-apps-enabled' is to prevent from the immature "signed package app code" interfering the "original packaged web app".

Comment 4

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=381c9aeed431

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8672486 [details] [diff] [review]
Bug1210235.patch

Review of attachment 8672486 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Henry. This is a very good step forward and resolves a few of my concerns when dealing with unsigned packages. r=me

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8672486 [details] [diff] [review]
Bug1210235.patch

Review of attachment 8672486 [details] [diff] [review]:
-----------------------------------------------------------------

I think you also need to update some of the unit tests for signed packages, setting this pref.

::: netwerk/protocol/http/PackagedAppVerifier.cpp
@@ +68,5 @@
>    static bool onceThru = false;
>    if (!onceThru) {
>      Preferences::AddBoolVarCache(&gDeveloperMode,
>                                   "network.http.packaged-apps-developer-mode", false);
> +    Preferences::AddBoolVarCache(&gSignedAppEnabled,

FYI, this variable does not seem to be in this patch. Maybe you have it left over in another patch.

Comment 7

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ed15a818667

Comment 8

[Henry Chang [:hchang]]

Attachment: Bug1210235 (r+'d, added missing variable declaration)

Comment 9

[Henry Chang [:hchang]]

Thanks Valentin! I am also aware of the missing variable declaration :p Have attached a new patch!

Comment 10

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ed15a818667

Comment 12

[Henry Chang [:hchang]]

Got a bunch of test failures. It seems I have to enable "network.http.packaged-signed-apps-enabled" in where we enable "network.http.packaged-apps-developer-mode".

Comment 13

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5380c1d5ecd

Comment 14

[Henry Chang [:hchang]]

Attachment: Bug1210235 (r+'d, fixed test cases and compile error)

Comment 15

[Henry Chang [:hchang]]

Attached a new patch to fix test case error and waiting for try result:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5380c1d5ecd

Comment 16

[Nigel Babu [:nigelb]]

Can you please sure the patches don't have try syntax? :)

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81c8989e5f61

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81c8989e5f61