1216566 - Fix a bug in nsIServiceWorkerManager.getAllRegistrations

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Eddy Bruel [:ejpbruel]]

Currently, nsIServiceWorkerManager.getRegistrations returns an array of nsIServiceWorkerInfos. This doesn't really make sense, because nsIServiceWorkerInfo represents a service worker, not a service worker registration, and these two concepts are not interchangeable.

Instead, nsIServiceWorkerManager.getRegistrations should return an array of nsIServiceWorkerRegistrationInfos. This will also eliminate the need to use a ServiceWorkerDataInfo to adapt a ServiceWorkerRegistrationInfo to implement the nsIServiceWorkerInfo interface.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Fix a bug in nsIServiceWorkerManager.getRegistrations

Comment 2

[Cătălin Badea (:catalinb)]

Comment on attachment 8676331 [details] [diff] [review]
Fix a bug in nsIServiceWorkerManager.getRegistrations

Review of attachment 8676331 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we want to drop about:serviceworkers just yet and removing those properties from nsIServiceWorkerInfo will break it.

::: dom/interfaces/base/nsIServiceWorkerManager.idl
@@ -30,5 @@
> -  readonly attribute DOMString scriptSpec;
> -  readonly attribute DOMString currentWorkerURL;
> -
> -  readonly attribute DOMString activeCacheName;
> -  readonly attribute DOMString waitingCacheName;

Removing these properties will break about:serviceworkers. 

They are still used here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutServiceWorkers.js#121

::: toolkit/content/aboutServiceWorkers.js
@@ +61,3 @@
>        continue;
>      }
> +/

Please remove this line.

Comment 3

[Eddy Bruel [:ejpbruel]]

Attachment: patch

New patch with comments addressed.

Comment 4

[Eddy Bruel [:ejpbruel]]

Try push for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f30814b3f86b

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a5d34242ce6

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8a5d34242ce6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8a5d34242ce6

Comment 8

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion