Closed
Bug 1217945
Opened 10 years ago
Closed 10 years ago
Remove unused objval argument to ToIdOperation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | affected |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
8.10 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8678276 -
Flags: review?(jdemooij)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
There is a reason for this code, I wanted to delete it before.
var a = {toString: function() { print("executed"); }};
x[a]++;
The toString should not execute.
|
|
||
Comment 3•10 years ago
|
||
(Assuming x is null/undefined)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8678276 [details] [diff] [review]
Remove useless objval argument to ToIdOperation
Review of attachment 8678276 [details] [diff] [review]:
-----------------------------------------------------------------
Patch looks good but clearing review per evilpie's comment. Maybe we should have a separate JSOp for the ToObject part?
Attachment #8678276 -
Flags: review?(jdemooij)
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•