1218499 - FetchEvent constructor will happily set mRequest to null if not passed

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

But the IDL says it can't be null, so I expect this:

  (new FetchEvent("foo")).request

to crash with a null-deref in binding code.

Looks to me like the spec at https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-section has the same bug (except it just doesn't say what to do if request is not set, as opposed to requiring a crash).

Chances are "request" should just be required in FetchEventInit.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, and looks like I mentioned this once before in bug 1065216 comment 3 and got ignored...

Comment 2

[Boris Zbarsky [:bzbarsky]]

I guess https://github.com/slightlyoff/ServiceWorker/issues/680 is the spec issue.  But we shouldn't wait for the spec to be fixed to stop crashing.  Probably need to just mark this member as nullable.

Comment 3

[(no longer active)]

Yeah we definitely crash here.

Comment 4

[(no longer active)]

Attachment: Make FetchEvent.request nullable

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8679059 [details] [diff] [review]
Make FetchEvent.request nullable

r=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/253416fea643

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/253416fea643