Closed Bug 1223452 Opened 10 years ago Closed 10 years ago

avoid Cu.importGlobalProperties in devtools

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file, 1 obsolete file)

avoid Cu.importGlobalProperties
7.40 KB, patch
tromey
: review+
Details | Diff | Splinter Review
Bug 1216234 had some issues that turned out to be that, at the end of a require chain, one file did Cu.importGlobalProperties -- and if this wasn't run, the code would fail. It's better to avoid importGlobalProperties and instead make special modules in Loader.jsm that can be required. This will avoid confusing results like that.
Attached patch avoid Cu.importGlobalProperties (obsolete) — — Splinter Review
Assignee: nobody → ttromey
Attachment #8685555 - Flags: review?(poirot.alex)
Comment on attachment 8685555 [details] [diff] [review] avoid Cu.importGlobalProperties Review of attachment 8685555 [details] [diff] [review]: ----------------------------------------------------------------- Note that Sandboxes have a significant memory cost. I think it's ok, but we should share a common sandbox if we start doing this for new symbols.
Attachment #8685555 - Flags: review?(poirot.alex) → review+
Rebased; added r= to commit.
Attachment #8685555 - Attachment is obsolete: true
Attachment #8688050 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1497b7791bda
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: