1225202 - Enable test_fileapi_slice.html with e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This is a continuation of bug 1224338. There are some more tests that need to be converted to use SpecialPowers.createFiles().

dom/base/test/test_fileapi_slice.html: This tests calls createFileWithData() from fileutils.js. I tried to convert it in the obvious way but it was failing to finish for some reason. I don't know if I was just exposing an existing race or causing one.

dom/base/test/test_mozfiledataurl.html: This tests has a getFile() method that uses getMyDirectory.sjs to create a File() relative to the test directory, rather than the profile directory, then loads some files. SpecialPowers.createFile() may need to be altered to handle this case.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Move some variables earlier in test_fileapi_slice.html.

imageLoadHandler, testBinaryData, fileData and size are used by all of
the subtests, so move their declarations earlier so they will remain
at the global scope when we start splitting scopes in preparation for
supporting asynchronous file creation.

memFile is only used in one subtest, so move it later.

code earlier that we want at the global scope
also move memFile down, which we don't want at the global scope

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fda4ac8a7b95

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Split each subtest in test_fileapi_slice.html into a separate function.

I'll attach a -w diff, too.

The files are put into single element arrays to prepare for the
SpecialPowers createFiles API.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Create files in test_fileapi_slice.html using SpecialPowers.createFiles.

This makes the test work with e10s enabled.

Remove createFileWithData from fileutils.js which is no longer used.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2, with -w

Most of the patch is whitespace changes, so it is easier to see what is happening in this version.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65666cb5ed18
https://hg.mozilla.org/integration/mozilla-inbound/rev/1da4e6787443
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7fa9a0b61f6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65666cb5ed18
https://hg.mozilla.org/mozilla-central/rev/1da4e6787443
https://hg.mozilla.org/mozilla-central/rev/e7fa9a0b61f6