1225361 - Use channel.asyncOpen2 in toolkit/components/places/tests/test_bug_411966.html

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1225361_test_bug_411966.patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8688241 [details] [diff] [review]
bug_1225361_test_bug_411966.patch

Review of attachment 8688241 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/test_bug_411966.html
@@ +27,5 @@
>  
> +        var clickedLinkChannel = NetUtil.newChannel({
> +                                   uri: clickedLinkURI,
> +                                   loadUsingSystemPrincipal: true,
> +                                   securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL

Might be worth fixing the default here before we convert too many callsites to use NetUtil.newChannel.

Technically it's fine that these callsites continue to explicitly set a flag, but stuff like this tends to get copied around the code since people aren't always aware what they do or don't have to do.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb056e694bb

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fb056e694bb