1225362 - Use channel.asyncOpen2 in toolkit/components/search/nsSearchService.js

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1225362_asyncopen2_nssearchservice.patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8688242 [details] [diff] [review]
bug_1225362_asyncopen2_nssearchservice.patch

Review of attachment 8688242 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/search/nsSearchService.js
@@ +877,5 @@
> +    return NetUtil.newChannel({
> +             uri: url,
> +             loadUsingSystemPrincipal: true,
> +             securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL
> +           });

This change will no longer be needed, right?

@@ +1458,5 @@
> +    var chan = NetUtil.newChannel({
> +                 uri: uri,
> +                 loadUsingSystemPrincipal: true,
> +                 securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL
> +               });

And you can drop the securityFlags here, right?

@@ +1527,5 @@
> +    var chan = NetUtil.newChannel({
> +                 uri: uri,
> +                 loadUsingSystemPrincipal: true,
> +                 securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL
> +               });

And here

@@ +1808,5 @@
> +        var chan = NetUtil.newChannel({
> +                     uri: uri,
> +                     loadUsingSystemPrincipal: true,
> +                     securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL
> +                   });

And here

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c91eff1c2734

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c91eff1c2734