1227207 - TypedArray constructor throws TypeError when it should throw RangeError

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Lars T Hansen [:lth]]

Today's mozilla-inbound.  I think it's been this way for a while.

The spec 22.2.1.5 says that TypedArray should throw RangeError if the start offset does not divide the element size or if the end offset minus the start offset does not divide the element size.  SpiderMonkey throws TypeError in both cases.

js> var AB = new ArrayBuffer(12)
js> new Int32Array(AB, 2)
typein:3:1 TypeError: invalid arguments
Stack:
  @typein:3:1
js> var BC = new ArrayBuffer(14)
js> new Int32Array(BC)
typein:5:1 TypeError: invalid arguments
Stack:
  @typein:5:1
js>

Comment 1

[Lars T Hansen [:lth]]

Jason, isn't there a bug for tracking spec deviations like this?

Comment 2

[Jason Orendorff [:jorendorff]]

No, there's not a separate meta bug for functionality that's implemented in a buggy way. Bug 694100 is the right block-ee for all deviations from spec.

Comment 3

[Lars T Hansen [:lth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3137dcd74310

Comment 4

[Lars T Hansen [:lth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=165047506ff4

Comment 5

[Lars T Hansen [:lth]]

Attachment: throw correct error type

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 8753827 [details] [diff] [review]
throw correct error type

Review of attachment 8753827 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/vm/TypedArrayObject.cpp
@@ +604,5 @@
>              buffer = static_cast<ArrayBufferObjectMaybeShared*>(&AsSharedArrayBuffer(bufobj));
>          }
>  
>          if (byteOffset > buffer->byteLength() || byteOffset % sizeof(NativeType) != 0) {
> +            JS_ReportErrorNumber(cx, GetErrorMessage, nullptr, JSMSG_BAD_INDEX);

The error message this makes is technically correct and *maybe* better than "invalid arguments" but not ideal.
We could splurge and add another error message to js.msg. Your call.

Comment 7

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8302c77d1f239ce9167eab689692d203d4cb5652
Bug 1227207 - throw correct error type.  r=jorendorff

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8302c77d1f23