1227361 - Remove checks for MOZ_SERVICES_SYNC from browser/

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

There are many references to MOZ_SERVICES_SYNC in the tree, but best we can tell, no one ever builds without that flag set. The flag doesn't have a huge cost, but it does add complexity and means we need to pre-process some modules that otherwise could be treated normally.

Can we just remove this flag?

Comment 1

[Mike Hommey [:glandium]]

b2, mobile/android and thunderbird are not setting it, so they are all effectively using it.

Comment 2

[Mike Hommey [:glandium]]

That said, since it's set in confvars.sh, you can feel free to remove the corresponding ifdefs in files under browser/. But that's not a build config bug.

Comment 3

[Marco Bonardo [:mak]]

Yeah, I think it's a good idea to remove it from browser/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Let's reuse that bug for that then!

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fb159b6db56

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8691462 [details] [diff] [review]
patch, v1

Review of attachment 8691462 [details] [diff] [review]:
-----------------------------------------------------------------

If there's any file that doesn't need anymore preprocessing (for example preferences.css) you should fix that in jar.mn or moz.build.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2

(In reply to Marco Bonardo [::mak] from comment #6)
> If there's any file that doesn't need anymore preprocessing (for example
> preferences.css) you should fix that in jar.mn or moz.build.
Hadn't checked the preprocessing of the .css files earlier today, and there for Windows and Linux the preprocessing can be removed. For the latter one, I removed the encapsulation of the license header in a |%if 0| block. All other files touched still have more preprocessing rules (the OS X theme an %include near the top).

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8691471 [details] [diff] [review]
patch, v2

Review of attachment 8691471 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/efa53e2c2992

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efa53e2c2992

Comment 11

[alexander]

Good day. Unfortunately, at least we used this flag. JFYI, here someone who still use it and some other flags.