1232444 - only persist service worker registrations that successfully install

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently we call StoreRegistration() immediately at the start of a registration or update.

Instead, we should wait until a service worker is successfully installed.  We have no facility to re-run the install event on startup, so if the browser closes before installation finishes we should just forget the registration anyway.  The page can start the register again when its next visited.

This will also fix some warning spam we currently have.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Only store service worker registrations after install is successful. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88e7324c213a

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eee01cc54bf

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae46539dbbc9

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Oh yea, we depend on bug 1231974.  This burned the tree since that hasn't landed yet.

Backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/55979cd464b0

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6428efb2c02

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a6428efb2c02