1232527 - [EME] Remove GMPVideoDecoderTrialCreator

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We can remove the GMPVideoDecoderTrialCreator now. We have simpler and more robust ways to tell whether gmp-clearkey can use WMF to decode AAC/H.264.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc5f12d0ae2bf6811dd624a46ccd38968277954
Bug 1232527 - Call into WMF PDM to determine if WMF can decode instead of using GMPVideoDecoderTrialCreator. r=jwwang

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac81258fcf5c9a36d2330dea2c338fd6e656f622
Bug 1232527 - Remove GMPVideoDecoderTrialCreator and friends. r=jwwang

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2fc5f12d0ae2
https://hg.mozilla.org/mozilla-central/rev/ac81258fcf5c

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 1: Call into WMF PDM to determine if WMF can decode instead of using GMPVideoDecoderTrialCreator.

Reviewboard put the review request for this bug in bug 1232514, since a patch for that bug was at the top of my queue when I pushed to review.


r=jwwang, in bug 1232514.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2: Remove GMPVideoDecoderTrialCreator and friends.

Importing from bug 1232514, which is where review-board put this.

r=jwwang, in bug 1232514.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8699133 [details] [diff] [review]
Patch 1: Call into WMF PDM to determine if WMF can decode instead of using GMPVideoDecoderTrialCreator.

Approval Request Comment
[Feature/regressing bug #]: Clearkey EME

[User impact if declined]:

Without this patch, some ClearKey EME demos won't work in Firefox.

This patch makes Gecko check on Windows whether the system has audio/video decoders installed before assuming that our ClearKey EME Content Decryption Module can use the system decoders to decode.

Without this patch, we'll just assume that all Vista and later systems have system H264/AAC decoders installed, but this assumption is not always true. 

[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests.

[Risks and why]: Low, our code to check whether the system has codecs is pretty mature now.

[String/UUID change made/needed]: None.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Note: we don't need to uplift patch 2, as that just removes old unused code, and in addition it changes the mozIGeckoMediaPluginService's UUID.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8699133 [details] [diff] [review]
Patch 1: Call into WMF PDM to determine if WMF can decode instead of using GMPVideoDecoderTrialCreator.

Needed for ClearKey EME demos, taking it for Beta44 and Aurora45.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b42b881d871b

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #8)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=b42b881d871b

Beta try push.

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7955c3961deb

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #10)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7955c3961deb

Aurora try push.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/586fe84e48ca

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/caa6bf47e04e

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/caa6bf47e04e