1233760 - Convert 25 tests within netwerk/test to use AsyncOpen2

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1233760_asyncOpen2_25_netwerk_tests.patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fc524031ec7

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e33b2a6d17d4

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

It seems the changes in this bug made it to mozilla-central, but the bug hasn't been updated (marked fixed). Probably because I had to back out one of the tests (see comment 3). Can someone of the sheriffs take a look? Thanks.

Comment 5

[Patrick McManus [:mcmanus]]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #4)
> It seems the changes in this bug made it to mozilla-central, but the bug
> hasn't been updated (marked fixed). Probably because I had to back out one
> of the tests (see comment 3). Can someone of the sheriffs take a look?
> Thanks.

why do you think that failed?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, the merge marking tool saw the word "revert" with a matching bug number, so left the bug open. Happy to close it manually if that one reverted test doesn't need to be relanded first.

Comment 7

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Patrick McManus [:mcmanus] from comment #5)
> (In reply to Christoph Kerschbaumer [:ckerschb] from comment #4)
> > It seems the changes in this bug made it to mozilla-central, but the bug
> > hasn't been updated (marked fixed). Probably because I had to back out one
> > of the tests (see comment 3). Can someone of the sheriffs take a look?
> > Thanks.
> 
> why do you think that failed?

It's odd, but that test does not even pass locally without using asyncOpen2. I created Bug 1234366 to investigate what's going on with that test.