1234351 - Animate "bookmarked" star when bookmarking from the overflow menu

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: GIF_bookmark_anim4.gif

Brought this up in bug 1227120, but I think this would likely be punted to be separate so I'm filing this bug. 

(In reply to Anthony Lam (:antlam) from comment #7)
> Created attachment 8700110 [details]
> mov_bookmarkanim1_device.mov
> 
> For context (maybe not this bug) - This is what I'm thinking for adding a
> bit of delight and whimsy to our bookmark star. It uses the rotation element
> of our iOS counter parts but keeps its position in the menu.
> 
> Couple points to avoid possible freak out:
> 
>  - Animation does take 500ms, so we should test out how delaying the
> dismissal of the menu will feel
>  - For comparison, closing the menu immediately could still work, we can
> reuse the confirmation screen style from our Share overlay work in bug
> 1147653 (imagine a star instead of a check)
>  - Improving the experience of bookmarking overall and could go a long way

Comment 1

[Jimmy]

I don't know if this is related, or whether I need to create a new bug: In my "Customize Firefox" page I have the "Bookmarks Toolbar Items, Bookmarks Menu" items, but the "Bookmarks" items (i.e., Bookmarked Star or Attribute) is missing from my "Address Bar". This behavior is new, & I can't get it back, although I followed all online suggestions regarding the dragging of the above items onto the toolbar.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.