1237799 - Fix up some plugin tests to use setTestPluginEnabledState

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Andrew McCreight [:mccr8]]

I found at least a couple of tests (test_bug827160.html and test_object.html) that seem to fail on e10s because they don't use setTestPluginEnabledState. There are probably more. These are easy to find and fix.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Move test_bug827160.html and test_object.html to plugins directory.

This will let these tests use plugin-utils.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b414592835ac

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use setTestPluginEnabledState in various tests.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8705760 [details] [diff] [review]
part 1 - Move test_bug827160.html and test_object.html to plugins directory.

When moving these tests to dom/plugins people working on nsObjectLoadingContent or related code in dom/base might miss running these locally.

Olli, do you have an opinion here or know who might have?

Comment 4

[Andrew McCreight [:mccr8]]

Yeah, I could just copy a couple of functions into the other DOM directory if people prefer. Though really, the proper solution is to fix SpecialPowers.setTestPluginEnabledState() so it works like the version in plugin-utils...

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8705760 [details] [diff] [review]
part 1 - Move test_bug827160.html and test_object.html to plugins directory.

I don't really mind. Given that lots of plugin tests are in dom/plugins, I'd
assume anyone doing major changes to nsObjectLoadingContent would need to run tests in dom/plugins anyway.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d82ae97a54ee
https://hg.mozilla.org/integration/mozilla-inbound/rev/63eb0a9b468d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d82ae97a54ee
https://hg.mozilla.org/mozilla-central/rev/63eb0a9b468d