Closed
Bug 1240958
Opened 10 years ago
Closed 10 years ago
[e10s] Fix test_bug414291.html to work in the absence of showModalDialog
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.71 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Bug 414291 looks like it was a regression from the landing of showModalDialog, wherein a window opened using window.open with modal=yes passed in was being opened as a modal dialog, but it shouldn't have been. The test checks that in two different scenarios with window.open we don't open a showModalDialog. These pass both with and without e10s. Arguably we're not in much danger of opening a modal window when we haven't implemented modal windows, but we might as well enable this.
The third test is this:
result3 = window.showModalDialog("data:text/html,<html><body onload='close(); returnValue = 3;'>");
is(result3, 3, "window didn't open as modal.");
I'm not entirely sure what this is testing. It just looks like a generic showModalDialog test. I could probably just delete it, but guarding it behind |if (window.showModalDialog)| makes it pass with e10s so I'll just do that.
|
Assignee | |
Comment 1•10 years ago
|
||
I'm going to optimistically assume that the only reason this simple test doesn't work on any of these platforms is due to showModalDialogue.
I've only tested this locally, with and without e10s.
Attachment #8709738 -
Flags: review?(mrbkap)
|
||
Updated•10 years ago
|
Attachment #8709738 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
|
|
Assignee | |
Comment 3•10 years ago
|
||
try for Android and B2G: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a946d43d4bb9&selectedJob=15696146
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•