Closed
Bug 1241252
Opened 10 years ago
Closed 10 years ago
[e10s] Fix test_bug61098.html to work with e10s
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
2.16 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
3.32 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
2.11 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
1.73 KB,
patch
|
Details | Diff | Splinter Review |
Bug 61098 added a way for the user to stop various modal dialogs, like alert() and showModalDialog(). We can just skip the ones about showModalDialog(), plus fix the way prefs are set, to get this working with e10s.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8710161 -
Flags: review?(mrbkap)
Assignee | ||
Comment 2•10 years ago
|
||
I'll attach a -w diff in a minute.
Attachment #8710162 -
Flags: review?(mrbkap)
Assignee | ||
Comment 3•10 years ago
|
||
Remove a redundant comment, check for the failure to throw an
exception, remove trailing whitespace.
Attachment #8710163 -
Flags: review?(mrbkap)
Assignee | ||
Comment 4•10 years ago
|
||
Updated•10 years ago
|
Attachment #8710161 -
Flags: review?(mrbkap) → review+
Updated•10 years ago
|
Attachment #8710162 -
Flags: review?(mrbkap) → review+
Updated•10 years ago
|
Attachment #8710163 -
Flags: review?(mrbkap) → review+
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment 6•10 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ddc78894cf28
https://hg.mozilla.org/mozilla-central/rev/65d4e80be3e3
https://hg.mozilla.org/mozilla-central/rev/1849d5f04ddc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•