Closed Bug 1246059 Opened 10 years ago Closed 4 years ago

Debug build crashed at shutting down if connected to Firefox sync (Assertion failure: isEmpty(), at dist/include/mozilla/LinkedList.h:328)

Categories

(Core :: JavaScript: GC, defect, P3)

Product:
Core
Component:
JavaScript: GC
Platform:
x86_64
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox47 --- affected

People

(Reporter: masayuki, Unassigned)

References

Details

(Keywords: crash, regression)

I'm not sure if this is exactly same bug as bug 1241841 because the STR isn't explained in the bug. Stack trace: >> xul.dll!mozilla::LinkedList<js::WeakMapBase>::~LinkedList<js::WeakMapBase>() Line 328 C++ > xul.dll!JS::Zone::~Zone() Line 64 C++ > xul.dll!js::gc::GCRuntime::sweepZones(js::FreeOp * fop, bool destroyingRuntime) Line 3796 C++ > xul.dll!js::gc::GCRuntime::endSweepPhase(bool destroyingRuntime) Line 5630 C++ > xul.dll!js::gc::GCRuntime::incrementalCollectSlice(js::SliceBudget & budget, JS::gcreason::Reason reason) Line 6139 C++ > xul.dll!js::gc::GCRuntime::gcCycle(bool nonincrementalByAPI, js::SliceBudget & budget, JS::gcreason::Reason reason) Line 6330 C++ > xul.dll!js::gc::GCRuntime::collect(bool nonincrementalByAPI, js::SliceBudget budget, JS::gcreason::Reason reason) Line 6436 C++ > xul.dll!js::gc::GCRuntime::gc(JSGCInvocationKind gckind, JS::gcreason::Reason reason) Line 6492 C++ > xul.dll!JSRuntime::~JSRuntime() Line 422 C++ > xul.dll!JS_DestroyRuntime(JSRuntime * rt) Line 482 C++ > xul.dll!mozilla::CycleCollectedJSRuntime::~CycleCollectedJSRuntime() Line 492 C++ > [External Code] > xul.dll!nsXPConnect::~nsXPConnect() Line 101 C++ > xul.dll!nsXPConnect::Release() Line 39 C++ > xul.dll!nsXPConnect::ReleaseXPConnectSingleton() Line 149 C++ > xul.dll!xpcModuleDtor() Line 24 C++ STR: 1. Create new profile with debug build 2. Connect with Firefox Sync (perhaps, you should wait for a while not to break your cloud data) 3. Close the Firefox Then, you must meet the crash. I cannot reproduce this bug while the profile is disconnected from Firefox Sync. I tested with x64 debug build on Win10 (built with VS 2013). I started to reproduce this bug at least a couple of months ago.
bug 1241841 was fixed but I still reproduce this bug :-(
(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #1) > bug 1241841 was fixed but I still reproduce this bug :-( I think we discovered the root cause of bug 1241841. I filed a patch to fix the issue.
Masayuki, now that Eddy's follow-up patch was merged and that bug 1241841 is closed again, are you still able to reproduce this bug?
Flags: needinfo?(masayuki)
Yeah, I can still reproduce this bug with my profile for debugging. After I disconnect it from Firefox Sync, shutting down becomes normally.
Flags: needinfo?(masayuki)
Note that we fixed two different causes for this bug: 1. Leaking a listener in the debugger server 2. Leaking a runnable in the worker debugger It's not inconceivable that there are other bugs like this that cause this crash to happen.
Terrence, do you have time to look into this? Based on our previous debugging session with rr, this shouldn't be *too* hard to find, provided it can be reproduced locally. (If you don't have time, that's totally ok too. Just let me know in that case.)
Flags: needinfo?(terrence)
(In reply to Eddy Bruel [:ejpbruel] from comment #6) > Terrence, do you have time to look into this? > > Based on our previous debugging session with rr, this shouldn't be *too* > hard to find, provided it can be reproduced locally. > > (If you don't have time, that's totally ok too. Just let me know in that > case.) I really don't have time at the moment. Besides, I wasn't paying close attention as you narrowed down on the solution last time, so I'm not really sure how to get from a GC/CC dump to the leaking edge.
Flags: needinfo?(terrence)
(returning needinfo so that you're aware of Terrence's reply)
Flags: needinfo?(ejpbruel)
I am. I marked this bug as P1. I really should look into it this week, but both the number of P1s for the debugger is growing faster than I can keep up with.
Flags: needinfo?(ejpbruel)
Priority: -- → P1
Priority: P1 → P3

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Hi Masayuki

Could you please let us know if this is still an issue with the latest firefox release? can we can close it?

thanks

Flags: needinfo?(masayuki)

Ah, no. I cannot reproduce this anymore.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(masayuki)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.