1249546 - [EME] Update Adobe CDM version to 17

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Chris Peterson [:cpeterson]]

@ Rail or catlee: can please point Firefox 47+ (Nightly) users at Adobe's new CDM v17? Once we are confident CDM v17 is working in Nightly, we can file a follow-up request to point Beta and Aurora users (45+) at CDM v17.

The latest drop of the Primetime CDM (v17) is available on the Adobe public endpoint:

https://cdmdownload.adobe.com/firefox/update.json

The x86 download URL is:

https://cdmdownload.adobe.com/firefox/win/x86/primetime_gmp_win_x86_gmc_40673.zip 

The x86 SHA-512 digest is: 

8aad35fc13814b0f1daacddb0d599eedd685287d5afddc97c2f740c8aea270636ccd75b1d1a57364b84e8eb1b23c9f1c126c057d95f3d8217b331dc4b1d5340f

The x64 download URL is:

https://cdmdownload.adobe.com/firefox/win/x64/primetime_gmp_win_x64_gmc_40673.zip 

The x64 SHA-512 digest is:

bd1e1a370c5f9dadc247c9f00dd203fab1a75ff3afed8439a0a0bfcc7e1767d0da68497140cbe48daa70e2535dde5f220dd7b344619cecd830a6b685efb9d5a0

Comment 1

[Justin Wood (:Callek)]

(In reply to Chris Peterson [:cpeterson] from comment #0)
> @ Rail or catlee: can please point Firefox 47+ (Nightly) users at Adobe's
> new CDM v17? Once we are confident CDM v17 is working in Nightly, we can
> file a follow-up request to point Beta and Aurora users (45+) at CDM v17.

Chris, rail just asked if I could take this. But I do have some stuff I was planning to do today which means this would slip until monday. Is that slip ok or is this of high enough priority that you feel it *must* be done today?

Comment 2

[Justin Wood (:Callek)]

(In reply to Justin Wood (:Callek) from comment #1)
> (In reply to Chris Peterson [:cpeterson] from comment #0)
> > @ Rail or catlee: can please point Firefox 47+ (Nightly) users at Adobe's
> > new CDM v17? Once we are confident CDM v17 is working in Nightly, we can
> > file a follow-up request to point Beta and Aurora users (45+) at CDM v17.
> 
> Chris, rail just asked if I could take this. But I do have some stuff I was
> planning to do today which means this would slip until monday. Is that slip
> ok or is this of high enough priority that you feel it *must* be done today?

Also we have the following rules/info in place today for the CDM (first matched is used):

[omitting aurora/beta/release rules]

CDM 16: -- CHANNEL "nightlytest"
 * Served to Windows XP only (64 bit OS's only)
 * && On Firefox 45+

CDM 15:  -- CHANNEL "nightlytest"
 * Served to Windows XP only (both x86 and 64-bit)
 * && on Firefox 42+

CDM 16:  -- CHANNEL "nightlytest"
 * Served to Vista and newer (64 bit OS's only)
 * && on Firefox 42+

CDM 15:  -- CHANNEL "nightlytest"
 * Served to Vista and newer (both x86 and 64-bit)
 * && on Firefox 42+

CDM 16: -- CHANNEL "nighthly"
 * Served to Vista and newer (64 bit OS's only)
 * && on Firefox 42+

CDM 15:  -- CHANNEL "nightly"
 * Served to Vista and newer (both x86 and 64-bit)
 * && on Firefox 42+

NO CDM: 
 * Everything else

So with that what are the requirements for CDM17, does it replace any of the above rules, does it require a Firefox newer than 42, is it to be shipped to XP?

Are we shipping to `nightlytest` ahead of `nightly`?

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Justin Wood (:Callek) from comment #1)
> Chris, rail just asked if I could take this. But I do have some stuff I was
> planning to do today which means this would slip until monday. Is that slip
> ok or is this of high enough priority that you feel it *must* be done today?

Thanks. Next week is not a problem. :)

Comment 4

[Justin Wood (:Callek)]

Chris, the answers to the questions in c#2 will help me make progress on this next week for you, without needing to nab you again...

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Justin Wood (:Callek) from comment #2)
> So with that what are the requirements for CDM17, does it replace any of the
> above rules, does it require a Firefox newer than 42, is it to be shipped to
> XP?

For CDM 17's initial rollout next week, I think we want to test:

CDM 17: -- CHANNEL "nightlytest"
 * Served to Windows XP and Vista and later (both x86 and 64-bit)
 * && On Firefox 47+ (i.e. the current Firefox Nightly)

CDM 17: -- CHANNEL "nightly"
 * Served to Windows XP and Vista and later (both x86 and 64-bit)
 * && on Firefox 47+ (i.e. the current Firefox Nightly)

If that Firefox 47 test looks good, then later in the week we will ask to include Firefox Aurora 46 and Beta 45:

CDM 17: -- CHANNEL "nightlytest"
 * Served to Windows XP and Vista and later (both x86 and 64-bit)
 * && On Firefox 45+ (i.e. the current Firefox Beta)
                 ^^

CDM 17: -- CHANNEL "nightly"
 * Served to Windows XP and Vista and later (both x86 and 64-bit)
 * && on Firefox 45+ (i.e. the current Firefox Beta)
                 ^^


> Are we shipping to `nightlytest` ahead of `nightly`?

I don't completely understand the difference between this channels, but Rail told me, in a January email, that `nightlytest` is used for QA before pushing to `nightly`. So, IIUC, shipping to `nightlytest` ahead of `nightly` is correct.

Comment 6

[Justin Wood (:Callek)]

(In reply to Chris Peterson [:cpeterson] from comment #5)
> (In reply to Justin Wood (:Callek) from comment #2)
> > So with that what are the requirements for CDM17, does it replace any of the
> > above rules, does it require a Firefox newer than 42, is it to be shipped to
> > XP?
> 
> For CDM 17's initial rollout next week, I think we want to test:
> 
> CDM 17: -- CHANNEL "nightlytest"
>  * Served to Windows XP and Vista and later (both x86 and 64-bit)
>  * && On Firefox 47+ (i.e. the current Firefox Nightly)
> 
> CDM 17: -- CHANNEL "nightly"
>  * Served to Windows XP and Vista and later (both x86 and 64-bit)
>  * && on Firefox 47+ (i.e. the current Firefox Nightly)
> 
> If that Firefox 47 test looks good, then later in the week we will ask to
> include Firefox Aurora 46 and Beta 45:

For our purposes here, I am looking for "what firefox version is this CDM `supported` with. And does that have the same answer for all OS's.

Specifically we shipped to 42/45+ for `nightly` even when the "current" nightly wasn't on those channels. Prior choices were to support for +X versions back, and thus the matrix we have now. The XP support was attempted recently, but QA discovered issues with XP and thus we deferred until "next CDM version"....

As far as difference between the channels `nightlytest` is only used by our internal developers/qa (on purpose) [or community who manually set it that way] and is never what any of our nightlies ship as, so is expected to be entirely internal. (as in, if we want our own QA/humans to test the update prior to giving it to any of our users, even our nightly users)

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Justin Wood (:Callek) from comment #6)
> For our purposes here, I am looking for "what firefox version is this CDM
> `supported` with. And does that have the same answer for all OS's.
> 
> Specifically we shipped to 42/45+ for `nightly` even when the "current"
> nightly wasn't on those channels. Prior choices were to support for +X
> versions back, and thus the matrix we have now. The XP support was attempted
> recently, but QA discovered issues with XP and thus we deferred until "next
> CDM version"....

CDM 17 is supposed to fix the XP issues. CDM 17 should be compatible with:

* Firefox version: "any", but I don't think we want to change the CDM version we serve to Firefox 44 or earlier (or at least not yet). That's why I suggested a smoke test with Firefox Nightly 47 users and then serve to Firefox 45+ (currently Beta), which would ride the trains to 45 release.
* OS: Windows XP, Vista, and later
* Processor: x86 and 64-bit. (As shown in comment 2, CDM 16 was a limited release only for 64-bit.)

Comment 8

[Justin Wood (:Callek)]

(In reply to Chris Peterson [:cpeterson] from comment #7)
> (In reply to Justin Wood (:Callek) from comment #6)
> > For our purposes here, I am looking for "what firefox version is this CDM
> > `supported` with. And does that have the same answer for all OS's.
> > 
> > Specifically we shipped to 42/45+ for `nightly` even when the "current"
> > nightly wasn't on those channels. Prior choices were to support for +X
> > versions back, and thus the matrix we have now. The XP support was attempted
> > recently, but QA discovered issues with XP and thus we deferred until "next
> > CDM version"....
> 
> CDM 17 is supposed to fix the XP issues. CDM 17 should be compatible with:
> 
> * Firefox version: "any", but I don't think we want to change the CDM
> version we serve to Firefox 44 or earlier (or at least not yet). That's why
> I suggested a smoke test with Firefox Nightly 47 users and then serve to
> Firefox 45+ (currently Beta), which would ride the trains to 45 release.
> * OS: Windows XP, Vista, and later
> * Processor: x86 and 64-bit. (As shown in comment 2, CDM 16 was a limited
> release only for 64-bit.)

Ok, let me try and give you some more prose, since I think we're a bit confused on what each other is saying...

When I say "Firefox version 42+" here, and "Channel: nightly" I literally mean "people running a `Nightly Branded` Firefox on versions 42 and up," this would not get anyone running an Aurora, beta, or release into the mix, just Nightly (e.g. users who for one reason or another didn't update Nightly)

Its just all about how I craft the rules, if I have the rules set to mark 42+ and thats what we support, then I can just directly duplicate when it is ready to ride trains for, 'aurora', then 'beta', etc and be great. If I specify 47+ for 'nightly' then I have to do manual work to make it 46+ when we switch to aurora's train, etc. And we lose out on people who haven't updated to the newest version of Firefox, even if we want to support those older versions.

Hope that prose helps. n-i again incase it adjusts your answer above.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Justin Wood (:Callek) from comment #8)
> When I say "Firefox version 42+" here, and "Channel: nightly" I literally
> mean "people running a `Nightly Branded` Firefox on versions 42 and up,"
> this would not get anyone running an Aurora, beta, or release into the mix,
> just Nightly (e.g. users who for one reason or another didn't update Nightly)

I see. I didn't realize that you could target Firefox versions *and* channels. I thought the `nightly` and `nightlytest` CDM "channels" (to use an overloaded term) referred to the frequency of update checks or something, not the Firefox "Nightly" channel.


> Its just all about how I craft the rules, if I have the rules set to mark
> 42+ and thats what we support, then I can just directly duplicate when it is
> ready to ride trains for, 'aurora', then 'beta', etc and be great. If I
> specify 47+ for 'nightly' then I have to do manual work to make it 46+ when
> we switch to aurora's train, etc. And we lose out on people who haven't
> updated to the newest version of Firefox, even if we want to support those
> older versions.

Can you target a Firefox version, regardless of channel? I think serving CDM 17 to Nightly users stuck on, say, Nightly 42 would be counterproductive. We don't care about incompatibilities in that old, Nightly code.

OTOH, serving CDM 17 to Firefox 47+ would target today's Nightly users and then ride the trains with 47+ like other Firefox features. We're trying to move away from pushing new CDM builds straight to Firefox Release users and towards riding the trains.

Comment 10

[Justin Wood (:Callek)]

So, while I *can* set it up to target a specific CDM version for a Firefox version, regardless of channel. Its not exactly easy at the moment, since along with the CDM we also have other things sharing these rules.

OpenH264 is one of those things...

So anytime we have to update one thing, we craft rules that meet the criteria on the whole matrix, e.g. "this version of openh264 is supported for these firefox versions on this channel, but we don't want to push it to release users until we see that its ok for beta users" etc.

But at the same time we need to craft those rules in such a way that makes sense for Adobe's CDM rollout, and all that.

cpearce did the planning/setup/etc for the last round I touched. I'm n-i'ing him for context/added info.

(I'm happy to do whatever, its just a matter of work/sanity, expectations)

(Yes chris is on PTo until the 23'rd and I can deploy to nightly/nightlytest in the meantime, but his input may help)

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Justin Wood (:Callek) from comment #10)
> cpearce did the planning/setup/etc for the last round I touched. I'm n-i'ing
> him for context/added info.
> 
> (I'm happy to do whatever, its just a matter of work/sanity, expectations)
> 
> (Yes chris is on PTo until the 23'rd and I can deploy to nightly/nightlytest
> in the meantime, but his input may help)

OK, let's just wait for cpearce to return from PTO before you make any changes, even to nightly/nightlytest. I don't want you to do unnecessary work if cpearce might make different recommendations. :)

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

I think we should remove the channel checking logic from our permanent rules.

I would like to move CDM updates closer to a Firefox-style train model, and target CDM versions to Firefox pre-release versions, and let new CDM versions only make it to the Firefox release channel once the Firefox version they're targeting makes it to release channel.

Now that we have lots and lots of people using the Adobe CDM on Netflix in Release Firefox, I don't want to be pushing rules that affect our release population straight to release unless it is an emergency. I want rules and the CDM to bake along with the Firefox version the CDM is tested against is baking in pre-release channels.

That is, when Adobe releases a new CDM version, I want to pick a pre-release Firefox version (say 46), and specify a rule saying "version >= 46 gets the new CDM version", deploy the rule change, and wait for Firefox 46 to hit the release channel.

So I'd be happy to remove the channel checks from our rules, and just have the Firefox version checks. Then when Firefox uplifts happen, the rules don't need to be recrafted.

The "nightlytest" channel I thought was entirely for releng to test their rules before making rule changes affect actual users. I've only ever seen it used this way, and never used it except when asked by nthomas or rail to verify that their rules are correct.

That is, I assumed the process was, releng person crafts the rules they expect Firefox to need for (channel=="nightlytest" && $otherRules), pushes that rule, then releng guy and/or I test that "nightlytest" is behaving as expected, and releng guy removes the 'channel=="nightlytest" &&' prefix from the rule and the rule starts to affect actual users.

As such, I think we can remove the "nightlytest" rules, and only use that channel temporarily while crafting rules.

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

I've tested the CDM v17 on Firefox 47 (Nightly) and Firefox 46 (Aurora) on Win32 and Win64. Please can we push out the CDM v17 to Firefox version 46 and later on 32bit Windows XP and later, and also to Win 7 and later for 64bit?

That is, can we have rules equivalent to:

CDM 17: Firefox >= 46, x86, WinXP and later.
CDM 17: Firefox >= 46, x64, Win7 and later.
CDM 16: Firefox >= 42 && Firefox < 46, x64, Win7 and later.
CDM 15: Firefox >= 42 && Firefox <= 46, x86, Win Vista and later.

Note: The rules from comment 2 say that we're pushing a x64 CDM out to Win Vista x64, but our system requirements page [1] says that we only support x64 builds on Win7 and later, so we can stop pushing x64 CDMs to Win Vista users.
 
[1] https://www.mozilla.org/en-US/firefox/44.0.2/system-requirements/

Comment 14

[Justin Wood (:Callek)]

Attachment: Balrog Release specification diff

Comment 15

[Justin Wood (:Callek)]

(In reply to Chris Pearce (:cpearce) from comment #13)
> I've tested the CDM v17 on Firefox 47 (Nightly) and Firefox 46 (Aurora) on
> Win32 and Win64. Please can we push out the CDM v17 to Firefox version 46
> and later on 32bit Windows XP and later, and also to Win 7 and later for
> 64bit?
> 
> That is, can we have rules equivalent to:
> 
> CDM 17: Firefox >= 46, x86, WinXP and later.
> CDM 17: Firefox >= 46, x64, Win7 and later.
> CDM 16: Firefox >= 42 && Firefox < 46, x64, Win7 and later.
> CDM 15: Firefox >= 42 && Firefox <= 46, x86, Win Vista and later.
> 
> Note: The rules from comment 2 say that we're pushing a x64 CDM out to Win
> Vista x64, but our system requirements page [1] says that we only support
> x64 builds on Win7 and later, so we can stop pushing x64 CDMs to Win Vista
> users.
>  
> [1] https://www.mozilla.org/en-US/firefox/44.0.2/system-requirements/

Ok, this is now done, (for CDM17) on 'nightlytest' -- chris can you test that and if it looks good I'll swap it to be irrespective of channel.

This is all set for Firefox >=46

I did not adjust any of the other existing rules for CDM 16/CDM15 due to the mess of CDM+Openh264 rules at the moment. But it is ripe for further cleanup/sanity.

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

This update has been deployed. CDM v17 is live.