1256313 - [e10s] <select> preserves active state when I release mouse over the list of options

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160313030418. DEFAULT THEME
STR (A),(B):
1. Open attached "testcase 1"
2. Hover mouse over the <select>'s dropmarker, hold left mouse button   [drop-down list will open]
3.A) Hover mouse over any visible option
3.B) Hover mouse over option the upper scroll button in scrollbar
4. Release left mouse button
5. Move mouse to urlbar and click in urlbar

STR (C),(D):
1. Open attached "testcase 1"
2. Click the <select>'s dropmarker   [drop-down list will open]
3.C) Hover mouse over any visible option. Click left mouse button.
3.D) Hover mouse over option the upper scroll button in scrollbar.
4. Do nothing
5. Move mouse to urlbar and click in urlbar

AR:
 (A,B)  Select has  :active  pseudoclass
 (C,D)  Select doesn't have  :active  pseudoclass

ER:
 Scenarios (A) and (C) should result in the same dropmarker state (e.g. not :active)
 Scenarios (B) and (D) should result in the same dropmarker state (e.g. not :active)

Note:
 I filed this bug separately from bug 1253979 just in case, because in bug 1253977 it became
 obvious that appearance of <select> may have nothing in common with pseudoclasses

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Jim: this is not great but I think it's polish. Setting P1, can you set to '+'? I don't have permissions to set '+'.

Comment 3

[Neil Deakin]

Attachment: Clear the active state on mouseup

This patch clears the active state of the select on mouseup, and does so just after the mouseup event fires. This seems to work ok.

There is an obscure edgecase not fixed which I don't think really matters: Click and hold then keydown and press enter (that is select an item with the keyboard while holding the mouse). The active state will clear on popup close rather than mouseup.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8772110 [details] [diff] [review]
Clear the active state on mouseup

Review of attachment 8772110 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac078f039076

Comment 6

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b41ba5363c60

Comment 7

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19d91134271f

Comment 8

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b361e455e6ab4c37c9368d5b9c914b22997efb7
Bug 1256313, clear active state on select button when releasing the mouse in e10s, r=mconley

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b361e455e6a

Comment 10

[Paul Silaghi, QA [:pauly]]

(In reply to arni2033 from comment #0)
> STR (A),(B):
> 1. Open attached "testcase 1"
> 2. Hover mouse over the <select>'s dropmarker, hold left mouse button  
> [drop-down list will open]
> 3.A) Hover mouse over any visible option
> 3.B) Hover mouse over option the upper scroll button in scrollbar
> 4. Release left mouse button
> 5. Move mouse to urlbar and click in urlbar
This is still reproducible if I release the left mouse button over the scrollbar.
Fx 50b11, Win 7 x64

Comment 11

[Neil Deakin]

Please file another bug on this issue.

Comment 12

[Paul Silaghi, QA [:pauly]]

Marking this as verified fixed on Fx 50b11 considering the follow-up bug 1314647.