1257484 - Deleting cookies via "Web Developer" and "Remove Cookie(s) for Site" add-ons doesn't work

Status: VERIFIED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[maggus.staab]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160315004019

Steps to reproduce:

Use Firefox with "Web Developer" addon.

A) Click "Cookies" -> "Delete Domain Cookies"

B) Click "cookies" -> "show domain cookies" -> "delete cookie"


Actual results:

no error, no cookies deleted


Expected results:

both, A) and B) should be valid ways to delete a cookie.

It seems to be a FF Dev Edition only issue.

Comment 1

[Loic]

This add-on is pretty old (no update since 2013). Do these functions work in FF45, or is it broken since FF47?

Comment 2

[Loic]

In addition, could you test with e10s (multiprocess) disabled and enabled in FF47, please.

Comment 3

[maggus.staab]

Same problem on FF47 non e10s build.
cookies also not deletable with extension https://addons.mozilla.org/en-US/firefox/addon/remove-cookies-for-site/ in FF47

In FF44 it works.

Comment 4

[maggus.staab]

might this be related to the issue I reported in parallel: https://bugzilla.mozilla.org/show_bug.cgi?id=1257483 ?

Comment 5

[maggus.staab]

Also in FF45 it works.

Comment 6

[Loic]

It's a side-effect of bug 1245184.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

HTTPS Everywhere is also affected by the change.

The interface is used by many of the add-ons -- baku, is it possible overload the function definition so we don't throw

NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsICookieManager2.remove]

if we know the function is called with the fewer number of arguments?

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

That's bug 1259169.

Comment 9

[Steve Workman [:sworkman] (INACTIVE)]

Hi [e-mail] - can you confirm if bug 1259169 fixed this please?

Comment 10

[Andrew Overholt [:overholt]]

QA, can you help verify comment 9? Thank you!

Comment 11

[maggus.staab]

confirmed, works in FF48 Dev Edition

Comment 12

[Andrew Overholt [:overholt]]

Thanks! Any chance you can confirm it works in 47 Beta (http://beta.mozilla.org/), too? (Sorry, I'm just having a hard time understanding the STR myself.)

Comment 13

[maggus.staab]

FF47 is no longer installed on my workstation (because it already updated to FF48).

regarding STR:

- Start Firefox with the "Web Developer" extension installed
- Visit a site from which you know, your browser uses/allows cookies

- From the "Web Developer" Toolbar choose "cookies" -> "show cookie information" (not 100% sure about the labels, because I am using a translated version of the extension)
-> expected result: a new tab is opened which contains information about the cookies
-> actual result (before this fix): the cookie list/table was empty
- Close the newly added tab again

- From the "Web Developer" Toolbar choose "cookies" -> "delete domain cookies"
-> expected result: confirm message, which shows how many cookies were deleted
-> actual result (before this fix): "0 cookies deleted" message

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking 48 as fixed (probably by bug 1259169) based on comment 11. It would be nice to verify the fix on 47 as well.

Comment 15

[Andrew Overholt [:overholt]]

(In reply to maggus.staab from comment #13)
> regarding STR:

Thanks for the clear STR! I can verify this is fixed in the 20160531183335 47 build.

Comment 16

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I tried reproducing the bug on the affected 48.0a1 build(20160323030400) and can confirm that it is reproducible.
Confirm the bug is fixed on the builds :   46.0.1 build(20160502172042) , 48.0a2 build (20160601004014)   47.0 build 1 (20160531183335).

Comment 17

[maggus.staab]

this seems to be broken again in FF50

Comment 18

[Loic]

(In reply to maggus.staab from comment #17)
> this seems to be broken again in FF50

I doubt it's broken again, I tested with the latest Aurora and the add-on "Remove Cookies" (https://addons.mozilla.org/en-US/firefox/addon/remove-cookies-for-site/) and it works fine. Could you create a fresh profile with Aurora, install the add-on and test, please.

Comment 19

[maggus.staab]

I can confirm it still works when using fresh profile from FF50 (2016-08-12).

Dont know what exactly is wonky with my profile, but it doesnt work there.
when using "Cookies -> Delete Domain cookies" nothing happens. no confirm window, no message, no error in the firefox console.