Closed
Bug 1260591
Opened 10 years ago
Closed 9 years ago
Move ServiceWorkerInfo and ServiceWorkerRegistrationInfo into their own files
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 2 obsolete files)
50.95 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
In the quest to make ServiceWorkerManager more maintainable we are splitting some of the code out into separate files. ServiceWorkerInfo and ServiceWorkerRegistrationInfo are already defined as separate classes. This bug just moves them to separate files.
The dependent and blocker bugs are mainly because this is the order in my patch queue.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
This follows on the work in bug 1256428. Its a mechanical move of the ServiceWorkerInfo and ServiceWorkerRegistrationInfo classes into their own files.
Attachment #8736072 -
Attachment is obsolete: true
Attachment #8736894 -
Flags: review?(josh)
Updated•10 years ago
|
Attachment #8736894 -
Flags: review?(josh) → review+
Backed out for build bustage on at least Windows like https://treeherder.mozilla.org/logviewer.html#?job_id=25441049&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/d576d5eba529
Flags: needinfo?(bkelly)
Assignee | ||
Comment 5•9 years ago
|
||
I had to move an #undef PostMessage. This is unified build bustage that only triggers on windows.
Attachment #8736894 -
Attachment is obsolete: true
Flags: needinfo?(bkelly)
Attachment #8739618 -
Flags: review+
Comment 7•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•