1264622 - MP4 not playing

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

The sample at location: http://dash.edgesuite.net/dash264/TestCases/3b/sony/DASH_vodaudio_Track8.m4a

part of the DASH-IF multi-audio tracks samples isn't playing.

Investigating shows that this video as a Specific Audio Config's Channel Configuration set to 0 which is "AOT Specific Config"

However, we have nothing to parse the AOT Specific Config.

Glancing at the libstagefrigth, they have added support for those.

We should resync this ESDS box parser.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1264622: [MP4] Resync stagefright's updateAudioTrackInfoFromESDS_MPEG4Audio with upstream. r?kentuckyfriedtakahe

This adds support for parsing AOT audio specific config (which contains extended channels layout).

Review commit: https://reviewboard.mozilla.org/r/46411/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46411/

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8741348 [details]
MozReview Request: Bug 1264622: [MP4] Resync stagefright's updateAudioTrackInfoFromESDS_MPEG4Audio with upstream. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/46411/#review43287

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8741348 [details]
MozReview Request: Bug 1264622: [MP4] Resync stagefright's updateAudioTrackInfoFromESDS_MPEG4Audio with upstream. r?kentuckyfriedtakahe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46411/diff/1-2/

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66e2cb107600

Comment 5

[Michelle Funches - QA]

Attachment: DisplayOfControls.png

Comment 6

[Michelle Funches - QA]

Set tracking for E10s: 
Version 	48.0a1
Build ID 	20160415030231
E10s Enabled: Controls can be seen
E10s Disabled: Controls cannot be seen
Reference attached DisplayOfControls

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66e2cb107600

Comment 8

[Jean-Yves Avenard [:jya]]

(In reply to Michelle Funches - QA from comment #5)
> Created attachment 8741835 [details]
> DisplayOfControls.png

But that would be prior the fix. Now the file is playing.