1268404 - implement ServoStyleSet::ResolveStyleForNonElement for text nodes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=847b89c7c8e5

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Part 1: Pass text node into ResolveStyleForNonElement.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 2: Implement ServoStyleSet::ResolveStyleForNonElement for text nodes.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8746456 [details] [diff] [review]
Part 1: Pass text node into ResolveStyleForNonElement.

Review of attachment 8746456 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsStyleSet.h
@@ +173,5 @@
>    // any rule matching for them is a first step.
>    // When text-combine-upright is not present, we may also want to avoid
>    // resolving style contexts for text frames as well.
>    already_AddRefed<nsStyleContext>
> +  ResolveStyleForNonElement(nsIContent* aContent,

Worth adding a comment about exactly what aContent refers to here, and when it is and isn't null.

Though to be honest, I think it would be cleaner to just have ResolveStyleForTextNode(nsIContent* aTextNode, nsStyleContext* aParentContext), and leave ResolveStyleForNonElement the way it is. This would avoid having a bunch of callers pass nullptr for the contextually-meaningless parameter.

The nsStyleSet implementation is pretty barebones, and our Servo implementation for these two cases seems like it's going to be pretty orthogonal.

What do you think?

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8746457 [details] [diff] [review]
Part 2: Implement ServoStyleSet::ResolveStyleForNonElement for text nodes.

Review of attachment 8746457 [details] [diff] [review]:
-----------------------------------------------------------------

r=me modulo the discussion regarding the previous patch.

Comment 6

[Cameron McCormack (:heycam)]

(In reply to Bobby Holley (busy) from comment #4)
> Though to be honest, I think it would be cleaner to just have
> ResolveStyleForTextNode(nsIContent* aTextNode, nsStyleContext*
> aParentContext), and leave ResolveStyleForNonElement the way it is. This
> would avoid having a bunch of callers pass nullptr for the
> contextually-meaningless parameter.

Sounds fair.

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Part 1: Split out ResolveStyleForText from ResolveStyleForNonEleme nt and pass in the text node.

Comment 8

[Cameron McCormack (:heycam)]

Attachment: Part 2: Implement ServoStyleSet::ResolveStyleForText. r=bholley

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1befe70618d1
https://hg.mozilla.org/integration/mozilla-inbound/rev/cadc30c3f197

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1befe70618d1
https://hg.mozilla.org/mozilla-central/rev/cadc30c3f197