1270447 - Printing via parent fails when using pref print.always_print_silent=true

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Bob Owen (:bobowen)]

+++ This bug was initially created as a clone of Bug #1255336 +++

Breaking this out from bug 1255336 as the reported problem there turned out to be a separate issue.

This fails because a RemotePrintJob hasn't been set up when printing silently.

Comment 1

[Marcia Knous [:marcia]]

Bob: Does this only affect Firefox 49 or other versions, and do we have STR?

Comment 2

[Bob Owen (:bobowen)]

(In reply to Marcia Knous [:marcia - use ni] from comment #1)
> Bob: Does this only affect Firefox 49 or other versions, and do we have STR?

Just Fx49, in fact it's Nightly only until we start to roll out the content sandbox, but that will hopefully be in Fx49.

STR are just to create print.always_print_silent=true pref on Windows and attempt to print.
(Assuming you're running with e10s and print.print_via_parent=true, which is the default.)

I'll be picking this up soon, anyway.

Comment 3

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1270447 Part 1: Use the RemotePrintJob's print settings in the parent when available.

Review commit: https://reviewboard.mozilla.org/r/54842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54842/

Comment 4

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob.

Review commit: https://reviewboard.mozilla.org/r/54844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54844/

Comment 5

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1270447 Part 3: Authorize silent printing via the parent.

Review commit: https://reviewboard.mozilla.org/r/54846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54846/

Comment 6

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1270447 Part 4: Remove redundant lines in nsPrintOptionsWin::DeserializeToPrintSettings.

Review commit: https://reviewboard.mozilla.org/r/54848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54848/

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8755845 [details]
MozReview Request: Bug 1270447 Part 1: Use the RemotePrintJob's print settings in the parent when available.

https://reviewboard.mozilla.org/r/54842/#review52196

::: layout/printing/ipc/RemotePrintJobParent.cpp:203
(Diff revision 1)
>    MOZ_ASSERT(aListener);
>  
>    mPrintProgressListeners.AppendElement(aListener);
>  }
>  
> +already_AddRefed<nsIPrintSettings> RemotePrintJobParent::GetPrintSettings()

nit - wrap this such that the return type is above the method name. looks like that matches the rest of the file.

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8755846 [details]
MozReview Request: Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob.

https://reviewboard.mozilla.org/r/54844/#review52200

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8755847 [details]
MozReview Request: Bug 1270447 Part 3: Authorize silent printing via the parent.

https://reviewboard.mozilla.org/r/54846/#review52202

Comment 10

[Jim Mathies [:jimm]]

Comment on attachment 8755848 [details]
MozReview Request: Bug 1270447 Part 4: Remove redundant lines in nsPrintOptionsWin::DeserializeToPrintSettings.

https://reviewboard.mozilla.org/r/54848/#review52204

Comment 11

[Bob Owen (:bobowen)]

Comment on attachment 8755845 [details]
MozReview Request: Bug 1270447 Part 1: Use the RemotePrintJob's print settings in the parent when available.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54842/diff/1-2/

Comment 12

[Bob Owen (:bobowen)]

Comment on attachment 8755846 [details]
MozReview Request: Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54844/diff/1-2/

Comment 13

[Bob Owen (:bobowen)]

Comment on attachment 8755847 [details]
MozReview Request: Bug 1270447 Part 3: Authorize silent printing via the parent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54846/diff/1-2/

Comment 14

[Bob Owen (:bobowen)]

Comment on attachment 8755848 [details]
MozReview Request: Bug 1270447 Part 4: Remove redundant lines in nsPrintOptionsWin::DeserializeToPrintSettings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54848/diff/1-2/

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34fa89cabbdb
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd97954bd82a
https://hg.mozilla.org/integration/mozilla-inbound/rev/1531cd2fb7e6
https://hg.mozilla.org/integration/mozilla-inbound/rev/386458c8b926

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34fa89cabbdb
https://hg.mozilla.org/mozilla-central/rev/fd97954bd82a
https://hg.mozilla.org/mozilla-central/rev/1531cd2fb7e6
https://hg.mozilla.org/mozilla-central/rev/386458c8b926