Closed
Bug 1272748
Opened 9 years ago
Closed 9 years ago
expose --enable-sm-promise in mozinfo
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 1 obsolete file)
1.75 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
Bug 911216 introduced an --enable-sm-promise config flag. The streams work in bug 1272697 is also going to depend on this flag. I'd like to mark the wpt tests in that bug dependent on this build configuration.
Therefore, I'd like to expose 'sm_promise' as a boolean in mozinfo.json.
Assignee | ||
Comment 1•9 years ago
|
||
See comment 0 for why I'd like to make this change.
Attachment #8752303 -
Flags: review?(ted)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8752303 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=ted
Ted is just getting back from PTO. Mike, can you take a look at this? Thanks!
Attachment #8752303 -
Flags: review?(ted) → review?(mshal)
![]() |
||
Comment 3•9 years ago
|
||
Comment on attachment 8752303 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=ted
Can you document 'sm_promise' in build/docs/mozinfo.rst?
Attachment #8752303 -
Flags: review?(mshal) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8752303 -
Attachment is obsolete: true
Attachment #8752325 -
Flags: review?(mshal)
![]() |
||
Comment 5•9 years ago
|
||
Comment on attachment 8752325 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=mshal
>+sm_promise
>+ Whether spidermonkey promises have been enabled or not. This is set
>+ by add --enable-sm-promise in the mozconfig.
nit: add -> adding ?
Attachment #8752325 -
Flags: review?(mshal) → review+
Comment 7•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•