1281114 - Convert devtools/client/debugger/test/mochitest/addon3.xpi to use channel.open2()

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1281114_addon3xpi_open2.patch

Hey Brian, when working on Bug 1279429 I realized that debugger/test/mochitest/addon3.xpi was still relying on using channel.open() instead of channel.open2().

All I have updated is the following; I replaced:

> let ioservice = Cc['@mozilla.org/network/io-service;1'].
>    getService(Ci.nsIIOService);
>  let channel = ioservice.newChannel2(uri, 'UTF-8', null, null, systemPrincipal,
>                                      null, Ci.nsILoadInfo.SEC_NORMAL,
>                                      Ci.nsIContentPolicy.TYPE_OTHER);
>  let stream = channel.open();

with the following code:

> Components.utils.import("resource://gre/modules/NetUtil.jsm");
>  let channel = NetUtil.newChannel({
>    uri: NetUtil.newURI(uri, 'UTF-8', null),
>    loadUsingSystemPrincipal: true
>  });
>  let stream = channel.open2();

In fact, the new code does exactly the same but relies on open2() instead of open(). It will pass all security checks since the channel loads using the systemPrincipal anyway - thanks!

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Does this have a green Try run?

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> Does this have a green Try run?

Passes locally on linux and mac, but let's make sure:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db0197864810

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

Here is a list of tests that uses the *.xpi we updated within this patch:
* browser_dbg_addon-panels.js
* browser_dbg_addon-sources.js
* browser_dbg_addon-workers-dbg-enabled.js
* browser_dbg_addonactor.js

They all run within M(dt3) - all pass!

Ready to checkin!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2a087cdfb00
Convert devtools/client/debugger/test/mochitest/addon3.xpi to use channel.open2() r=grinstead

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2a087cdfb00

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2a087cdfb00

Comment 8

[Andy McKay]

When you changed this add-on did you get it resigned? It's currently causing test failures when we enforce signing.

Comment 9

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Andy McKay [:andym] from comment #8)
> When you changed this add-on did you get it resigned? It's currently causing
> test failures when we enforce signing.

No I didn't; sorry I was not aware of that. What do I have to do to get it right?

Comment 10

[Andy McKay]

I think we've got it in bug 1282868, if the tests pass a quick check that the addon change I've made on that bug would be cool. I'm still confused why this didn't fail as soon as it hit master though...

Comment 11

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Andy McKay [:andym] from comment #10)
> I think we've got it in bug 1282868,

Awesome, thanks!

Comment 12

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #11)
> (In reply to Andy McKay [:andym] from comment #10)
> > I think we've got it in bug 1282868,

Andy, I suppose Bug 1282868 fixed the signing problem, right? If so, I suppose we can finally mark this bug as resolved.

Comment 13

[Andy McKay]

Sorry about the delay, yes we can close this now. Thanks.