1282084 - RDM touch simulation mode triggers hover states

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Benoit Chabod [:bigben]]

The RDM touch simulation mode captures mouse events pretty well, and should be easy to use once Bug 1269882 has landed. However, it still triggers CSS :hover states, whereas this shouldn't be the case on a mobile device.

[Steps to reproduce]:
1. Launch Firefox.
2. Enable the devtools.responsive.html.enabled pref, and restart Firefox if necessary
3. Open http://www.w3schools.com/cssref/tryit.asp?filename=trycss_sel_hover, or any website using CSS hover states
4. Launch RDM on this website
5. Move your mouse over elements using this to see how it looks
6. Now enable touch simulation. You might have to reload the iframe by calling reload() on it in the console.
7. Move your mouse over these elements again.

[Expected result]:
- The hover state doesn't trigger anymore. There should only be a visible change when you click on the link/element ("sticky" hover).

[Actual result]:
- The hover state is still triggered. We shouldn't be able to interact with the page this way.

Comment 1

[Brad Werth [:bradwerth]]

https://patrickhlauke.github.io/touch/css-dropdown/mouse-only.html is a good test case for this.

Comment 3

[Micah [:mtigley] (she/her)]

After briefly looking into this issue with Patrick, it looks like we can remove element hover states by calling the InspectorUtils' removeContentStateon the target element. The AccessibleWalkerActor does something similar here: https://searchfox.org/mozilla-central/rev/ddd1679c0534f7ddf36cafddd17b710c4fefe3c4/devtools/server/actors/accessibility/walker.js#605-626 .

So I imagine we can do the same thing in TouchSimulator's handleEvent.

Comment 4

[Micah [:mtigley] (she/her)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c24ca1f81a187b6bfbf29ebeb308c19e88364c7e

Comment 5

[Micah [:mtigley] (she/her)]

Attachment: Bug 1282084 - Don't allow RDM to show triggered hover states while touch is enabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106e58c798ef
Don't allow RDM to show triggered hover states while touch is enabled. r=pbro

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/106e58c798ef

Comment 8

[Rares Doghi, Desktop QA]

This issue is verified as fixed in Nightly 69.0a1 (2019-06-03).