1282985 - "ASSERTION: No Document Request!" with <iframe>, <video>, <svg:use>

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: No Document Request!: 'mDocumentRequest', file uriloader/base/nsDocLoader.cpp, line 695

###!!! ASSERTION: Firing OnStateChange(...) notification with a NULL request!: 'aRequest', file uriloader/base/nsDocLoader.cpp, line 1248

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Andrew Overholt [:overholt]]

smaug may know what's up here.

http://searchfox.org/mozilla-central/source/uriloader/base/nsDocLoader.cpp#695

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

ok, so because of flushing in nsDocLoader::DocLoaderIsEmpty we re-enter the method and end up clearing document request.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: docloader_unusual_reentrancy.diff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dda0bdc51eb0e9d69b4f741af752fb2805f8ccc

I went through couple of other options, but I think this quick-and-dirty is actually the best and safest.
The re-entrancy happens when we after layout flush run script runners and stop frameloader's docshell.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8766585 [details] [diff] [review]
docloader_unusual_reentrancy.diff

Review of attachment 8766585 [details] [diff] [review]:
-----------------------------------------------------------------

Ok ... I guess.

Comment 6

[Jesse Ruderman]

Is there a more direct way to test this kind of thing? The fragile setTimeout cascade was hard to work with and won't make a reliable regression test.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

perhaps dholbert might be able to comment about that, given that this is about svg:use, which does some rather unusual stuff in layout.

Comment 8

[Daniel Holbert [:dholbert]]

Sorry, I haven't had a recent enough interaction with the <use> mechanics (and the flushes / loader stuff involved here) to have a solid suggestion for comment 6.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc0469634a5
don't try to notify about page load of already stopped page, r=khuey

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fc0469634a5