1290018 - [WebGL2] pass gl.getInternalformatParameter() in gl-object-get-calls.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

getInternalformatParameter() should return invalid enum with DEPTH_STENCIL.

gles spec 3.0.4 p212
An internal format is depth-renderable if it is one of the formats from table 3.14. No other formats are depth-renderable.

In table 3.14 (p133), DEPTH_STENCIL is not in that table.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Sorry, comment 0 is incorrect.

In webgl2 spec:
void renderbufferStorage(GLenum target, GLenum internalformat, GLsizei width, GLsizei height) (OpenGL ES 3.0.4 §4.4.2, man page)
Accepts internal formats from OpenGL ES 3.0 as detailed in the specification and man page.
To be backward compatible with WebGL 1, also accepts internal format DEPTH_STENCIL, which should be mapped to DEPTH24_STENCIL8 by implementations.

So the DEPTH_STENCIL is valid.
Please check Bug 1241702.

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Try to update the test
https://github.com/KhronosGroup/WebGL/pull/1945

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Is my understanding correct for comment 1?

Comment 4

[Kelsey Gilbert [:jgilbert]]

(In reply to Jerry Shih[:jerry] (UTC+8) from comment #3)
> Is my understanding correct for comment 1?

Yes though technically I don't think this exception necessarily applies to getInternalformatParameter.
It should though.

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update webgl conformance tests. v1

Add DEPTH_STENCIL to depth-renderable list.
https://github.com/KhronosGroup/WebGL/pull/1945

Just pick that change.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

cherry-pick webgl conformance patch.
Please the attachment 8775830 [details] [diff] [review] to m-c.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22b93575a3d9
update webgl conformance tests. r=jgilbert

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22b93575a3d9