1306217 - Implement the layout for <input type=datetime-local>

Status: RESOLVED DUPLICATE of bug 1283388

(Core :: Layout: Form Controls, enhancement, P3)

Comment 1

[Dino Kovač]

Can someone please update the status of datetime-local? Is there a plan to work on this feature in the near future?

Comment 2

[Sebastian Zartner [:sebo]]

See bug 888320 comment 47 for the status.

Sebastian

Comment 5

[vincent.enjalbert]

Another URL : https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input/datetime-local

Strangely, https://developer.mozilla.org/fr/docs/Web/HTML/Element/input/date and https://developer.mozilla.org/fr/docs/Web/HTML/Element/input/time are already implemented.

The support of datetime-local could be such a relief for many people. I want to see if I can contribute on this. Is there a guide on how to contribute ?

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to vincent.enjalbert from comment #5)

Another URL : https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input/datetime-local

Strangely, https://developer.mozilla.org/fr/docs/Web/HTML/Element/input/date and https://developer.mozilla.org/fr/docs/Web/HTML/Element/input/time are already implemented.

The support of datetime-local could be such a relief for many people. I want to see if I can contribute on this. Is there a guide on how to contribute ?

Hi, thank you for the interest in contribution.
For general information, https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide could be a good start for you.
For this specific bug, you would need to refer to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1069609 to follow the UX spec. I am not sure how easy this bug is for a new contributor, but I believe Emilio can share more thoughts. :)

Comment 7

[Emilio Cobos Álvarez [:emilio]]

It's probably not too hard to come up with something that we can put behind a pref and works. We can then iterate on it as needed.

The main code for the widget and such is in datetimebox.js. There you also need to handle the datetime-local type.

There are a couple checks in HTMLInputElement.cpp like this which also need to account for DATETIME_LOCAL. I recommend creating a helper like InputTypeUsesUAWidget for this, and replace the current checks checking mType directly.

You should also change this line to create the same kind of frame (layout box) as we have for time and date inputs (so, replacing NS_NewTextControlFrame by NS_NewDateTimeControlFrame. I think that should mostly work out of the box

That should get you most of the way there. Then you'd need to implement the functionality of the input in datetimebox.js and the styling in datetimebox.css.

Not sure if you'll hit any issue with those steps (I hope not!), but if you do I'm happy to help, just needinfo? me or send a patch for review and I can provide feedback in Phabricator.

Thank you!

Comment 8

[vincent.enjalbert]

Thank you both !
I can't promise anything for now, I have to check all of this first :) Will do asap.

Comment 9

[vincent.enjalbert]

Sorry guys, something came up here, and I have no free time anymore.
I still keep this in mind though, but atm I can't tell when I will have time again :(
I'll keep this thread updated if any news.

Comment 10

[lafeber]

Is there any news on implementing this? Firefox (desktop) is currently the only browser that doesn't support this :(

Comment 11

[Ashish Kumar Jha]

Yeah, Even Safari has now started to support this from TP 117. Firefox is the only major browser that doesn't support it :(

Comment 12

[lafeber]

(In reply to lafeber from comment #10)

Is there any news on implementing this? Firefox (desktop) is currently the only browser that doesn't support this :(

The most recent development seems to be here: https://bugzilla.mozilla.org/show_bug.cgi?id=1283388

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Yeah, there's a patch in bug 1283388 which works but basically needs tests. I'm busy with other stuff atm, so if someone wants to help out that'd be awesome :)

Comment 14

[Sebastian Zartner [:sebo]]

Emilio, after fixing bug 1283388, is there anything left for this bug? Or can this one be closed in favor of the other one?

Sebastian

Comment 15

[Emilio Cobos Álvarez [:emilio]]

I don't think so.