1309202 - stylo: Factor out branch dispatch utilities

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

It is pretty boring to write the same thing again...

I think we can at least factor the following stuffs:
* IsServo() / IsGecko() / AsServo() / AsGecko(), declarations and inline definitions
* the macros FORWARD_CONCRETE and FORWARD


The methods are relatively easy. Some macros would be enough.

The macros are a bit harder, for two things:
1. I have no idea about the naming
2. we cannot do currying on macros (can we?)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Hmmm, actually not that hard :)

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1309202 - Factor out stylo branch dispatch utilities.

Review commit: https://reviewboard.mozilla.org/r/84870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84870/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8799733 [details]
Bug 1309202 - Factor out stylo branch dispatch utilities.

https://reviewboard.mozilla.org/r/84870/#review84084

::: layout/style/ServoUtils.h:26
(Diff revision 1)
> +  bool IsServo() const { return false; }
> +#endif
> +
> +/**
> + * Macro used in a base class of |geckotype_| and |servotype_|.
> + * The class should defines |StyleBackendType mType;| itself.

s/defines/define/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/802c8d996c9a
Factor out stylo branch dispatch utilities. r=heycam

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/802c8d996c9a