Closed
Bug 1310094
Opened 9 years ago
Closed 9 years ago
Remove UserCustomizations.jsm
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
13.36 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8800976 -
Flags: review?(myk)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8800981 -
Flags: review?(mcmanus)
Updated•9 years ago
|
Attachment #8800981 -
Flags: review?(mcmanus) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8800976 [details] [diff] [review]
Remove UserCustomizations.jsm
Review of attachment 8800976 [details] [diff] [review]:
-----------------------------------------------------------------
netwerk/ipc/NeckoParent.cpp also references nsIAppsService::isExtensionResource:
https://dxr.mozilla.org/mozilla-central/rev/9079d167112122805f99f57bb8856e1b1675af0f/netwerk/ipc/NeckoParent.cpp#663
So that needs to be removed as well.
Attachment #8800976 -
Flags: review?(myk) → review-
Assignee | ||
Comment 4•9 years ago
|
||
Did you have a fix in mind instead of attachment 8800981 [details] [diff] [review]?
Flags: needinfo?(myk)
Updated•9 years ago
|
Attachment #8800976 -
Flags: review- → review+
Comment 5•9 years ago
|
||
(In reply to :Ehsan Akhgari from comment #4)
> Did you have a fix in mind instead of attachment 8800981 [details] [diff] [review]
> [review]?
Ah, no, sorry, I missed that you'd fixed that in a separate patch. r+ in that case.
Flags: needinfo?(myk)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6588006ec86e
Part 1: Remove support for loading b2g extensions from AllocPRemoteOpenFileParent; r=mcmanus
https://hg.mozilla.org/integration/mozilla-inbound/rev/e71ee6ee03c3
Part 2: Remove UserCustomizations.jsm; r=myk
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6588006ec86e
https://hg.mozilla.org/mozilla-central/rev/e71ee6ee03c3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•