1313202 - [EME] Resolve MediaKeySession.closed before the promise returned by MediaKeySession.close()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The EME spec requires us to resolve the promise returned by MediaKeySession.close() after the MediaKeySession.close promise attribute. We're currently doing the opposite for both ClearKey and Widevine.

This causes us to fail these WPT:
http://www.w3c-test.org/encrypted-media/drm-mp4-playback-temporary-events.html
http://www.w3c-test.org/encrypted-media/clearkey-mp4-playback-temporary-events.html

WPT issue which updated the WPT to this behaviour:
https://github.com/w3c/web-platform-tests/issues/4058

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1313202 - Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close().

Review commit: https://reviewboard.mozilla.org/r/88748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88748/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1313202 - Update MediaKeySession.close() to match EME spec.

Review commit: https://reviewboard.mozilla.org/r/88750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88750/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8804930 [details]
Bug 1313202 - Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close().

https://reviewboard.mozilla.org/r/88748/#review87830

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8804931 [details]
Bug 1313202 - Update MediaKeySession.close() to match EME spec.

https://reviewboard.mozilla.org/r/88750/#review87832

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

I'm reliably informed that Chrome is converting the Widevine CDM's InvalidAccessErrors to TypeErrors:

https://cs.chromium.org/chromium/src/media/blink/cdm_result_promise_helper.cc?sq=package:chromium&dr=CSs&rcl=1477509663&l=42

So we should do the same in the WidevineDecryptor to get the drm variant of this test to pass.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1313202 - Convert InvalidAccessErrors coming out of the Widevine CDM to TypeErrors like Chrome does.

Review commit: https://reviewboard.mozilla.org/r/88760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88760/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8804930 [details]
Bug 1313202 - Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88748/diff/1-2/

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8804931 [details]
Bug 1313202 - Update MediaKeySession.close() to match EME spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88750/diff/1-2/

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8804950 [details]
Bug 1313202 - Convert InvalidAccessErrors coming out of the Widevine CDM to TypeErrors like Chrome does.

https://reviewboard.mozilla.org/r/88760/#review87856

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f6ae961e354
Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/2017b66912e8
Update MediaKeySession.close() to match EME spec. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b3275f223e26
Convert InvalidAccessErrors coming out of the Widevine CDM to TypeErrors like Chrome does. r=gerald

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f6ae961e354
https://hg.mozilla.org/mozilla-central/rev/2017b66912e8
https://hg.mozilla.org/mozilla-central/rev/b3275f223e26