1313584 - Hit MOZ_CRASH(GFX: Unhandled pname) at /Volumes/firefoxos/gecko-dev/dom/canvas/WebGLSampler.cpp:112

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vincent Liu[:vliu]]

Attachment: stack-dump.log

Found on Nightly build.

STR:
1. Load dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/samplerstatequery.html

Comment 1

[Vincent Liu[:vliu]]

Attachment: Add complete parameters handling for SamplerParameterX to cover test need.

To fulfill the whole test coverage in [1], the proposed patch intends to handle all of this. [1] was be called by [2] and [3] for different type.

[1]: https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/es3fSamplerStateQueryTests.js#152
[2]: https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/es3fSamplerStateQueryTests.js#125
[3]: https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/webgl-conf/checkout/deqp/functional/gles3/es3fSamplerStateQueryTests.js#135

Comment 2

[Vincent Liu[:vliu]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&tochange=3b8e8245bf62&fromchange=3c6c078b293f1ff829197689ac53047aca754dea&selectedJob=30418326

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd64f2ee2d83
Add complete parameters handling for SamplerParameterX to cover test need. r=mtseng

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd64f2ee2d83

Comment 5

[Vincent Liu[:vliu]]

[Tracking Requested - why for this release]: This bug is for fixing webgl2 conformance test crashed. We need this fix uplift to FF-51.

Comment 6

[Gerry Chang [:gchang]]

Track 51+ as this is Web GL 2 conformance test. 

Hi :vliu, 
Do you think this is worth uplifting to 51 aurora?

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8805465 [details] [diff] [review]
Add complete parameters handling for SamplerParameterX to cover test need.

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment 8

[Vincent Liu[:vliu]]

(In reply to Gerry Chang [:gchang] from comment #6)
> Track 51+ as this is Web GL 2 conformance test. 
> 
> Hi :vliu, 
> Do you think this is worth uplifting to 51 aurora?

Yes and thanks to Jeff for requesting aurora.

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8805465 [details] [diff] [review]
Add complete parameters handling for SamplerParameterX to cover test need.

WebGL 2 is the feature we want to ship in 51. Aurora51+.

Comment 10

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4e97dee28c69