1314542 - [DateTimeInput] input field cleared unexpectedly when using up/down keys

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jessica Jong [:jessica] (inactive)]

When millisecond field is empty, using up/down keys in other fields will clear all the fields unexpectedly.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Check for millisecond as well when setting input element's value, otherwise it will try to set input element's value to "hh:mm:ss." which is not a valid time string, hence value becomes empty string.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8807446 [details] [diff] [review]
patch, v1.

Review of attachment 8807446 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: toolkit/content/widgets/datetimebox.xml
@@ +328,5 @@
>              } else if (aTargetField == this.mMinuteField) {
>                value = now.getMinutes();
>              } else if (aTargetField == this.mSecondField) {
>                value = now.getSeconds();
> +            } else if (aTargetField == this.mMillisecField) {

Gah! Good catch!

Comment 4

[Jessica Jong [:jessica] (inactive)]

Thanks Mike!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bde90d0f871&group_state=expanded&selectedJob=30535188
failures seems not related to this bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eab190f5dc94
Verify millisecond field when setting input time elemet's value. r=mconley

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/eab190f5dc94