Closed Bug 1317308 Opened 8 years ago Closed 8 years ago

\s should no longer match U+180E in regular expressions

Categories

(Core :: JavaScript: Standard Library, defect)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug1317308.patch
13.43 KB, patch
arai
: review+
Details | Diff | Splinter Review
`assertEq(/\s/.exec("\u180e"), null)` should pass.
Attached patch bug1317308.patch — — Splinter Review
We should probably generate the constants in irregexp/RegExpEngine.cpp through vm/make_unicode.py, but for now this quick fix should suffice.
Attachment #8810530 - Flags: review?(arai.unmht)
Comment on attachment 8810530 [details] [diff] [review] bug1317308.patch Review of attachment 8810530 [details] [diff] [review]: ----------------------------------------------------------------- Great! yeah, I agree that the table should be automatically generated.
Attachment #8810530 - Flags: review?(arai.unmht) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/94615002eb6e Don't match Mongolian vowel separator as white space in regular expressions. r=arai
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94615002eb6e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: