1317374 - Annex B.3.3.1 should not be applied when a parameter with the same name is present

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
(function(f) {
  if (true) function f() {  }
  assertEq(f, 123);
}(123));
---

Expected: Passes
Actual: Throws "Error: Assertion failed: got function f() {  }, expected 123"


ES2017 spec:

The second condition in B.3.3.1, step 1.a.ii doesn't seem to be checked in SpiderMonkey:
---
If replacing the FunctionDeclaration f with a VariableStatement that has F as a BindingIdentifier would not produce any Early Errors for func
and
F is not an element of parameterNames, then [...]
---

https://tc39.github.io/ecma262/#sec-web-compat-functiondeclarationinstantiation

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Don't do Annex B lexical function behavior when redeclaring a parameter name.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc794806128
Don't do Annex B lexical function behavior when redeclaring a parameter name. (r=Waldo)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for spidermonkey bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=68988367&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e96ce6d55f7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4bae3e495a
Don't do Annex B lexical function behavior when redeclaring a parameter name. (r=Waldo)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f4bae3e495a